From: <grygorii.strashko@linaro.org>
To: Javier Martinez Canillas <javier@dowhile0.org>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
ssantosh@kernel.org, Kevin Hilman <khilman@deeprootsystems.com>,
tony@atomide.com
Cc: linux-omap@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org,
Grygorii Strashko <grygorii.strashko@linaro.org>
Subject: [PATCH v2 4/8] gpio: omap: drop 'gpio' param from omap_gpio_init_irq()
Date: Mon, 23 Mar 2015 14:18:26 +0200 [thread overview]
Message-ID: <1427113110-20813-5-git-send-email-grygorii.strashko@linaro.org> (raw)
In-Reply-To: <1427113110-20813-1-git-send-email-grygorii.strashko@linaro.org>
From: Grygorii Strashko <grygorii.strashko@linaro.org>
The 'gpio' parameter isn't needed any more as it
duplicates 'offset' parameter, so drop it.
Tested-by: Tony Lindgren <tony@atomide.com>
Tested-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Acked-by: Santosh Shilimkar <ssantosh@kernel.org>
Acked-by: Javier Martinez Canillas <javier@dowhile0.org>
Signed-off-by: Grygorii Strashko <grygorii.strashko@linaro.org>
---
drivers/gpio/gpio-omap.c | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
index 2df693b..ff5d54d 100644
--- a/drivers/gpio/gpio-omap.c
+++ b/drivers/gpio/gpio-omap.c
@@ -479,14 +479,13 @@ static int omap_gpio_is_input(struct gpio_bank *bank, unsigned offset)
return readl_relaxed(reg) & BIT(offset);
}
-static void omap_gpio_init_irq(struct gpio_bank *bank, unsigned gpio,
- unsigned offset)
+static void omap_gpio_init_irq(struct gpio_bank *bank, unsigned offset)
{
if (!LINE_USED(bank->mod_usage, offset)) {
omap_enable_gpio_module(bank, offset);
omap_set_gpio_direction(bank, offset, 1);
}
- bank->irq_usage |= BIT(GPIO_INDEX(bank, gpio));
+ bank->irq_usage |= BIT(offset);
}
static int omap_gpio_irq_type(struct irq_data *d, unsigned type)
@@ -518,7 +517,7 @@ static int omap_gpio_irq_type(struct irq_data *d, unsigned type)
spin_lock_irqsave(&bank->lock, flags);
offset = GPIO_INDEX(bank, gpio);
retval = omap_set_gpio_triggering(bank, offset, type);
- omap_gpio_init_irq(bank, gpio, offset);
+ omap_gpio_init_irq(bank, offset);
if (!omap_gpio_is_input(bank, offset)) {
spin_unlock_irqrestore(&bank->lock, flags);
return -EINVAL;
@@ -803,15 +802,14 @@ exit:
static unsigned int omap_gpio_irq_startup(struct irq_data *d)
{
struct gpio_bank *bank = omap_irq_data_get_bank(d);
- unsigned int gpio = omap_irq_to_gpio(bank, d->hwirq);
unsigned long flags;
- unsigned offset = GPIO_INDEX(bank, gpio);
+ unsigned offset = d->hwirq;
if (!BANK_USED(bank))
pm_runtime_get_sync(bank->dev);
spin_lock_irqsave(&bank->lock, flags);
- omap_gpio_init_irq(bank, gpio, offset);
+ omap_gpio_init_irq(bank, offset);
spin_unlock_irqrestore(&bank->lock, flags);
omap_gpio_unmask_irq(d);
--
1.9.1
next prev parent reply other threads:[~2015-03-23 12:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-23 12:18 [PATCH v2 0/8] gpio: omap: cleanup: get rid of system GPIO <-> GPIO offset converseations grygorii.strashko
2015-03-23 12:18 ` [PATCH v2 1/8] gpio: omap: convert omap_gpio_is_input() to use gpio offset grygorii.strashko
2015-03-27 10:03 ` Linus Walleij
2015-03-23 12:18 ` [PATCH v2 2/8] gpio: omap: simplify omap_set_gpio_dataout_x() grygorii.strashko
2015-03-27 10:04 ` Linus Walleij
2015-03-23 12:18 ` [PATCH v2 3/8] gpio: omap: convert debounce functions switch to use gpio offset grygorii.strashko
2015-03-27 10:05 ` Linus Walleij
2015-03-23 12:18 ` grygorii.strashko [this message]
2015-03-27 10:05 ` [PATCH v2 4/8] gpio: omap: drop 'gpio' param from omap_gpio_init_irq() Linus Walleij
2015-03-23 12:18 ` [PATCH v2 5/8] gpio: omap: convert gpio irq functions to use GPIO offset grygorii.strashko
2015-03-27 10:06 ` Linus Walleij
2015-03-23 12:18 ` [PATCH v2 6/8] gpio: omap: get rid of GPIO_BIT() macro grygorii.strashko
2015-03-27 10:07 ` Linus Walleij
2015-03-23 12:18 ` [PATCH v2 7/8] gpio: omap: get rid of omap_irq_to_gpio() grygorii.strashko
2015-03-27 10:08 ` Linus Walleij
2015-03-23 12:18 ` [PATCH v2 8/8] gpio: omap: get rid of GPIO_INDEX() macro grygorii.strashko
2015-03-27 10:09 ` Linus Walleij
2015-03-27 10:27 ` [PATCH v2 0/8] gpio: omap: cleanup: get rid of system GPIO <-> GPIO offset converseations Grygorii.Strashko@linaro.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427113110-20813-5-git-send-email-grygorii.strashko@linaro.org \
--to=grygorii.strashko@linaro.org \
--cc=gnurou@gmail.com \
--cc=javier@dowhile0.org \
--cc=khilman@deeprootsystems.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=ssantosh@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).