* [PATCH 03/11] drivers/gpio: include <module.h> for modular crystalcove code
[not found] <1430444867-22342-1-git-send-email-paul.gortmaker@windriver.com>
@ 2015-05-01 1:47 ` Paul Gortmaker
2015-05-12 7:38 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Paul Gortmaker @ 2015-05-01 1:47 UTC (permalink / raw)
To: linux-kernel; +Cc: Paul Gortmaker, Linus Walleij, Alexandre Courbot, linux-gpio
This file is built off of a tristate Kconfig option and also contains
modular function calls so it should explicitly include module.h to
avoid compile breakage during header shuffles done in the future.
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Alexandre Courbot <gnurou@gmail.com>
Cc: linux-gpio@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
drivers/gpio/gpio-crystalcove.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/gpio-crystalcove.c b/drivers/gpio/gpio-crystalcove.c
index 91a7ffe83135..cf28ec525e93 100644
--- a/drivers/gpio/gpio-crystalcove.c
+++ b/drivers/gpio/gpio-crystalcove.c
@@ -16,6 +16,7 @@
*/
#include <linux/interrupt.h>
+#include <linux/module.h>
#include <linux/platform_device.h>
#include <linux/gpio.h>
#include <linux/seq_file.h>
--
2.2.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 03/11] drivers/gpio: include <module.h> for modular crystalcove code
2015-05-01 1:47 ` [PATCH 03/11] drivers/gpio: include <module.h> for modular crystalcove code Paul Gortmaker
@ 2015-05-12 7:38 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2015-05-12 7:38 UTC (permalink / raw)
To: Paul Gortmaker
Cc: linux-kernel@vger.kernel.org, Alexandre Courbot,
linux-gpio@vger.kernel.org
On Fri, May 1, 2015 at 3:47 AM, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:
> This file is built off of a tristate Kconfig option and also contains
> modular function calls so it should explicitly include module.h to
> avoid compile breakage during header shuffles done in the future.
>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Alexandre Courbot <gnurou@gmail.com>
> Cc: linux-gpio@vger.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-05-12 7:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1430444867-22342-1-git-send-email-paul.gortmaker@windriver.com>
2015-05-01 1:47 ` [PATCH 03/11] drivers/gpio: include <module.h> for modular crystalcove code Paul Gortmaker
2015-05-12 7:38 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).