From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Bolle Subject: Re: [PATCH v3 3/8] mfd: arizona: Add support for WM8998 and WM1814 Date: Mon, 04 May 2015 12:44:14 +0200 Message-ID: <1430736254.23580.2.camel@tiscali.nl> References: <1430493319-23808-1-git-send-email-rf@opensource.wolfsonmicro.com> <1430493319-23808-4-git-send-email-rf@opensource.wolfsonmicro.com> <1430560731.2187.70.camel@x220> <20150504091119.GA32076@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150504091119.GA32076@opensource.wolfsonmicro.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Richard Fitzgerald Cc: gnurou@gmail.com, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linus.walleij@linaro.org, patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org, cw00.choi@samsung.com, broonie@kernel.org, myungjoo.ham@samsung.com, linux-gpio@vger.kernel.org, ckeepax@opensource.wolfsonmicro.com, lee.jones@linaro.org List-Id: linux-gpio@vger.kernel.org Richard Fitzgerald schreef op ma 04-05-2015 om 10:11 [+0100]: > Yes, I've noticed that these tests are wrong and I'm working on a patch for > it. Glad to hear I wasn't misreading that Makefile. > It's another one of those cases where more lines needs patching to fix > it than the 3 lines this WM8998 patch adds, and also fixing it potentially > breaks the build because of dependencies that were accidentally working > because they never got compiled out. So I'd prefer not to half-fix it in > these WM8998 patches it's better to let the code settle and then fix it properly. I see. Unless that fix takes very long to land, I won't be bothering you about this again. Thanks, Paul Bolle