From: Grygorii Strashko <grygorii.strashko@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Grygorii Strashko <grygorii.strashko@linaro.org>,
Johan Hovold <johan@kernel.org>
Subject: [PATCH v2 3/3] gpiolib: debugfs: identify gpios requested as irq only
Date: Wed, 20 May 2015 13:30:23 +0300 [thread overview]
Message-ID: <1432117823-1834-4-git-send-email-grygorii.strashko@linaro.org> (raw)
In-Reply-To: <1432117823-1834-1-git-send-email-grygorii.strashko@linaro.org>
Now many of GPIO drivers implement two interfaces gpiolib and irqchip
which are essentially orthogonal. So, now GPIO line can be requested
in three ways:
1) As pure GPIO (gpioX_request())
2) As pure GPIO IRQ, especially in DT boot case.
DT:
interrupt-parent = <&gpio6>;
interrupts = <11 IRQ_TYPE_EDGE_FALLING>;
Code:
platform_get_irq() or of_irq_get()
request_irq()
3) combination of (1) and (2).
And from GPIO debugfs it could be identified when GPIO is
requested/used or used as IRQ, but there is no way to determine
when GPIO is requested/used as IRQ only.
Such information is useful for debugging, so update GPIO debugfs code
to show marker '<irq-only>' for GPIO lines which are requested/used as
GPIO IRQ only.
After this patch sys/kernel/debug/gpio will produce following output:
...
GPIOs 160-191, platform/4805d000.gpio, gpio:
gpio-171 ((null) ) in hi IRQ-209 <irq-only>
GPIOs 192-223, platform/48051000.gpio, gpio:
gpio-203 (vtt_fixed ) out hi
Cc: Johan Hovold <johan@kernel.org>
Signed-off-by: Grygorii Strashko <grygorii.strashko@linaro.org>
---
drivers/gpio/gpiolib.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index f1dcb5b..d69fc58 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -2272,8 +2272,11 @@ static void gpiolib_dbg_show(struct seq_file *s, struct gpio_chip *chip)
chip->get
? (chip->get(chip, i) ? "hi" : "lo")
: "? ");
- if (is_irq)
+ if (is_irq) {
seq_printf(s, " IRQ-%d", gpiod_to_irq(gdesc));
+ if (!test_bit(FLAG_REQUESTED, &gdesc->flags))
+ seq_puts(s, " <irq-only>");
+ }
seq_printf(s, "\n");
}
}
--
1.9.1
next prev parent reply other threads:[~2015-05-20 10:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 10:30 [PATCH v2 0/3] gpiolib: debugfs: update to show more info for gpios requested as irq Grygorii Strashko
2015-05-20 10:30 ` [PATCH v2 1/3] gpiolib: debugfs: display gpios requested as irq only Grygorii Strashko
2015-06-01 12:50 ` Linus Walleij
2015-05-20 10:30 ` [PATCH v2 2/3] gpiolib: debugfs: show linux irq number for gpios requested as irq Grygorii Strashko
2015-06-01 12:51 ` Linus Walleij
2015-05-20 10:30 ` Grygorii Strashko [this message]
2015-06-01 12:52 ` [PATCH v2 3/3] gpiolib: debugfs: identify gpios requested as irq only Linus Walleij
2015-05-21 4:02 ` [PATCH v2 0/3] gpiolib: debugfs: update to show more info for gpios requested as irq Alexandre Courbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432117823-1834-4-git-send-email-grygorii.strashko@linaro.org \
--to=grygorii.strashko@linaro.org \
--cc=gnurou@gmail.com \
--cc=johan@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).