* [PATCH] gpio: tb10x: Drop unneeded free_irq() call
@ 2015-05-28 9:26 Axel Lin
2015-05-28 12:45 ` christian.ruppert
2015-06-02 9:26 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2015-05-28 9:26 UTC (permalink / raw)
To: Linus Walleij; +Cc: Christian Ruppert, Alexandre Courbot, linux-gpio
Current code uses devm_request_irq() in .probe, so drop the unneeded
free_irq() call in .remove.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/gpio/gpio-tb10x.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpio/gpio-tb10x.c b/drivers/gpio/gpio-tb10x.c
index 46b8961..12c99d9 100644
--- a/drivers/gpio/gpio-tb10x.c
+++ b/drivers/gpio/gpio-tb10x.c
@@ -292,7 +292,6 @@ static int tb10x_gpio_remove(struct platform_device *pdev)
BIT(tb10x_gpio->gc.ngpio) - 1, 0, 0);
kfree(tb10x_gpio->domain->gc);
irq_domain_remove(tb10x_gpio->domain);
- free_irq(tb10x_gpio->irq, tb10x_gpio);
}
gpiochip_remove(&tb10x_gpio->gc);
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: tb10x: Drop unneeded free_irq() call
2015-05-28 9:26 [PATCH] gpio: tb10x: Drop unneeded free_irq() call Axel Lin
@ 2015-05-28 12:45 ` christian.ruppert
2015-06-02 9:26 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: christian.ruppert @ 2015-05-28 12:45 UTC (permalink / raw)
To: Axel Lin; +Cc: Christian Ruppert, Alexandre Courbot, Linus Walleij, linux-gpio
Axel Lin <axel.lin@ingics.com> wrote on 05/28/2015 11:26:10 AM:
>
> Current code uses devm_request_irq() in .probe, so drop the unneeded
> free_irq() call in .remove.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Christian Ruppert <christian.ruppert@alitech.com>
> ---
> drivers/gpio/gpio-tb10x.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-tb10x.c b/drivers/gpio/gpio-tb10x.c
> index 46b8961..12c99d9 100644
> --- a/drivers/gpio/gpio-tb10x.c
> +++ b/drivers/gpio/gpio-tb10x.c
> @@ -292,7 +292,6 @@ static int tb10x_gpio_remove(struct platform_device
*pdev)
> BIT(tb10x_gpio->gc.ngpio) - 1, 0, 0);
> kfree(tb10x_gpio->domain->gc);
> irq_domain_remove(tb10x_gpio->domain);
> - free_irq(tb10x_gpio->irq, tb10x_gpio);
> }
> gpiochip_remove(&tb10x_gpio->gc);
>
> --
> 2.1.0
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: tb10x: Drop unneeded free_irq() call
2015-05-28 9:26 [PATCH] gpio: tb10x: Drop unneeded free_irq() call Axel Lin
2015-05-28 12:45 ` christian.ruppert
@ 2015-06-02 9:26 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2015-06-02 9:26 UTC (permalink / raw)
To: Axel Lin; +Cc: Christian Ruppert, Alexandre Courbot, linux-gpio@vger.kernel.org
On Thu, May 28, 2015 at 11:26 AM, Axel Lin <axel.lin@ingics.com> wrote:
> Current code uses devm_request_irq() in .probe, so drop the unneeded
> free_irq() call in .remove.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Patch applied with Christians ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-06-02 9:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-28 9:26 [PATCH] gpio: tb10x: Drop unneeded free_irq() call Axel Lin
2015-05-28 12:45 ` christian.ruppert
2015-06-02 9:26 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).