[PATCH] gpio: promote own request failure to pr_err()

[PATCH] gpio: promote own request failure to pr_err()

[Linus Walleij]

These error messages are helpful to see that we fail to get
hogs. Promote them to real errors so they appear in the boot
crawl.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/gpio/gpiolib.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 6bc612b8a49f..4861b2db2edc 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -2118,13 +2118,13 @@ int gpiod_hog(struct gpio_desc *desc, const char *name,
 
 	local_desc = gpiochip_request_own_desc(chip, hwnum, name);
 	if (IS_ERR(local_desc)) {
-		pr_debug("requesting own GPIO %s failed\n", name);
+		pr_err("requesting own GPIO %s failed\n", name);
 		return PTR_ERR(local_desc);
 	}
 
 	status = gpiod_configure_flags(desc, name, lflags, dflags);
 	if (status < 0) {
-		pr_debug("setup of GPIO %s failed\n", name);
+		pr_err("setup of GPIO %s failed\n", name);
 		gpiochip_free_own_desc(desc);
 		return status;
 	}
-- 
2.4.2

Re: [PATCH] gpio: promote own request failure to pr_err()

[Linus Walleij]

On Fri, Jun 5, 2015 at 11:10 AM, Linus Walleij <linus.walleij@linaro.org> wrote:

> These error messages are helpful to see that we fail to get
> hogs. Promote them to real errors so they appear in the boot
> crawl.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Bah I realize these are debug prints due to deferred probe
that would give unreasonable noise. Dropping this patch.

Yours,
Linus Walleij