[PATCH] gpio: improve error reporting on own descriptors

[PATCH] gpio: improve error reporting on own descriptors

[Linus Walleij]

When requesting own descriptors through hogs, it is useful to
get some details about what's going on if we encounter problems.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/gpio/gpiolib.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 4861b2db2edc..2d01a691060b 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -2118,13 +2118,15 @@ int gpiod_hog(struct gpio_desc *desc, const char *name,
 
 	local_desc = gpiochip_request_own_desc(chip, hwnum, name);
 	if (IS_ERR(local_desc)) {
-		pr_err("requesting own GPIO %s failed\n", name);
+		pr_err("requesting own GPIO %s (chip %s, offset %d) failed\n",
+		       name, chip->label, hwnum);
 		return PTR_ERR(local_desc);
 	}
 
 	status = gpiod_configure_flags(desc, name, lflags, dflags);
 	if (status < 0) {
-		pr_err("setup of GPIO %s failed\n", name);
+		pr_err("setup of GPIO %s (chip %s, offset %d) failed\n",
+		       name, chip->label, hwnum);
 		gpiochip_free_own_desc(desc);
 		return status;
 	}
-- 
2.4.2

Re: [PATCH] gpio: improve error reporting on own descriptors

[Alexandre Courbot]

On Fri, Jun 5, 2015 at 6:36 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
> When requesting own descriptors through hogs, it is useful to
> get some details about what's going on if we encounter problems.

Acked-by: Alexandre Courbot <acourbot@nvidia.com>

Linus, I apologize for my inactivity lately - hopefully I will have
some more time to spend on GPIO reviews. Thanks for your patience!