From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tien Hock Loh <thloh@altera.com>
Subject: Re: [PATCH 2/2] gpio: altera: fix return value of
 altera_gpio_remove()
Date: Sun, 21 Jun 2015 18:36:25 -0700
Message-ID: <1434936985.20199.8.camel@ubuntu>
References: <1434542383-21314-1-git-send-email-yamada.masahiro@socionext.com>
	 <1434542383-21314-2-git-send-email-yamada.masahiro@socionext.com>
	 <CAAVeFuJoeN4O6Cc1Wsm+Ev+K6sT0PqNq1QtX-ZQp1ePGVUbiPA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Return-path: <linux-gpio-owner@vger.kernel.org>
Received: from mail-bn1bon0063.outbound.protection.outlook.com ([157.56.111.63]:52096
	"EHLO na01-bn1-obe.outbound.protection.outlook.com"
	rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
	id S1751326AbbFVDKO convert rfc822-to-8bit (ORCPT
	<rfc822;linux-gpio@vger.kernel.org>); Sun, 21 Jun 2015 23:10:14 -0400
In-Reply-To: <CAAVeFuJoeN4O6Cc1Wsm+Ev+K6sT0PqNq1QtX-ZQp1ePGVUbiPA@mail.gmail.com>
Sender: linux-gpio-owner@vger.kernel.org
List-Id: linux-gpio@vger.kernel.org
To: Alexandre Courbot <gnurou@gmail.com>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>, "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>, Linus Walleij <linus.walleij@linaro.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>

Sorry I was away from my mail for the past few weeks. 
This isn't intentional, should be a bug I overlook. The fix is correct.

On Sun, 2015-06-21 at 16:25 +0900, Alexandre Courbot wrote:
> On Wed, Jun 17, 2015 at 8:59 PM, Masahiro Yamada
> <yamada.masahiro@socionext.com> wrote:
> > The remove callback never succeeds, which seems odd.
> >
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> > ---
> >
> > I wonder why nobody has pointed this out before me.
> > I am suspecting -EIO might be intentional.
> > I hope some Altera guys will give me comments.
> >
> >
> >  drivers/gpio/gpio-altera.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpio/gpio-altera.c b/drivers/gpio/gpio-altera.c
> > index c653c83..5861550 100644
> > --- a/drivers/gpio/gpio-altera.c
> > +++ b/drivers/gpio/gpio-altera.c
> > @@ -339,7 +339,7 @@ static int altera_gpio_remove(struct platform_device *pdev)
> >
> >         of_mm_gpiochip_remove(&altera_gc->mmchip);
> >
> > -       return -EIO;
> > +       return 0;
> 
> That looks weird indeed. Tien, can you comment on this?

--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in