From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>
Cc: linux-gpio@vger.kernel.org, kernel@pengutronix.de,
Pavel Machek <pavel@ucw.cz>, Sakari Ailus <sakari.ailus@iki.fi>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
linux-media@vger.kernel.org
Subject: [PATCH gpio-for-next 05/10] media: i2c/adp1653: set enable gpio to output
Date: Mon, 6 Jul 2015 11:09:45 +0200 [thread overview]
Message-ID: <1436173790-29963-5-git-send-email-u.kleine-koenig@pengutronix.de> (raw)
In-Reply-To: <20150706090759.GS11824@pengutronix.de>
Without setting the direction of a gpio to output a call to
gpiod_set_value doesn't have a defined outcome.
Furthermore this is one caller less that stops us making the flags
argument to gpiod_get*() mandatory.
Acked-by: Sakari Ailus <sakari.ailus@iki.fi>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/media/i2c/adp1653.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/adp1653.c b/drivers/media/i2c/adp1653.c
index c70ababce954..5dd39775d6ca 100644
--- a/drivers/media/i2c/adp1653.c
+++ b/drivers/media/i2c/adp1653.c
@@ -465,7 +465,7 @@ static int adp1653_of_init(struct i2c_client *client,
of_node_put(child);
- pd->enable_gpio = devm_gpiod_get(&client->dev, "enable");
+ pd->enable_gpio = devm_gpiod_get(&client->dev, "enable", GPIOD_OUT_LOW);
if (!pd->enable_gpio) {
dev_err(&client->dev, "Error getting GPIO\n");
return -EINVAL;
--
2.1.4
next prev parent reply other threads:[~2015-07-06 9:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-15 21:36 [PATCH] gpio: make flags mandatory for gpiod_get functions Uwe Kleine-König
2015-06-21 6:51 ` Alexandre Courbot
2015-07-06 9:07 ` [PULL gpio-for-next] " Uwe Kleine-König
2015-07-06 9:09 ` [PATCH gpio-for-next 01/10] drm/msm/dp: use flags argument of devm_gpiod_get to set direction Uwe Kleine-König
2015-07-06 9:09 ` [PATCH gpio-for-next 02/10] drm/tilcdc: panel: make better use of gpiod API Uwe Kleine-König
[not found] ` <20150706090759.GS11824-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2015-07-06 9:09 ` [PATCH gpio-for-next 03/10] iio: light: stk3310: use flags argument of devm_gpiod_get Uwe Kleine-König
2015-07-06 9:35 ` Breana, Tiberiu A
2015-07-06 9:09 ` [PATCH gpio-for-next 04/10] iio: magn: bmc150: " Uwe Kleine-König
2015-07-06 9:09 ` [PATCH gpio-for-next 09/10] usb: pass flags parameter to gpiod_get functions Uwe Kleine-König
2015-07-06 9:09 ` Uwe Kleine-König [this message]
2015-07-06 9:09 ` [PATCH gpio-for-next 06/10] NFC: nxp-nci_i2c: use flags argument of devm_gpiod_get_index Uwe Kleine-König
2015-07-06 9:09 ` [PATCH gpio-for-next 07/10] phy: tusb1210: make better use of gpiod API Uwe Kleine-König
2015-07-06 9:09 ` [PATCH gpio-for-next 08/10] usb: dwc3: pci: " Uwe Kleine-König
2015-07-06 9:09 ` [PATCH gpio-for-next 10/10] gpio: make flags mandatory for gpiod_get functions Uwe Kleine-König
2015-07-08 10:51 ` [PULL gpio-for-next] " Uwe Kleine-König
2015-07-15 6:28 ` Uwe Kleine-König
2015-07-15 6:39 ` Alexandre Courbot
2015-07-17 12:28 ` Linus Walleij
2015-07-20 6:56 ` Uwe Kleine-König
2015-07-20 7:41 ` Linus Walleij
2015-07-20 7:51 ` Uwe Kleine-König
2015-07-20 8:28 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436173790-29963-5-git-send-email-u.kleine-koenig@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=gnurou@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=pavel@ucw.cz \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).