* [PATCH] gpiolib: remove unneeded assignation
@ 2015-07-07 20:22 Laurent Navet
2015-07-13 14:20 ` Alexandre Courbot
2015-07-16 13:51 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Laurent Navet @ 2015-07-07 20:22 UTC (permalink / raw)
To: linus.walleij, gnurou; +Cc: linux-gpio, linux-kernel, Laurent Navet
ret is assigned value from of_property_read_string_index but is
overwritten before being used so remove it.
Also fix coverity CID 1309759
Signed-off-by: Laurent Navet <laurent.navet@gmail.com>
---
drivers/gpio/gpiolib-of.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c
index a6c67c6..346da01 100644
--- a/drivers/gpio/gpiolib-of.c
+++ b/drivers/gpio/gpiolib-of.c
@@ -365,7 +365,7 @@ static void of_gpiochip_add_pin_range(struct gpio_chip *chip)
if (pinspec.args[2]) {
if (group_names) {
- ret = of_property_read_string_index(np,
+ of_property_read_string_index(np,
group_names_propname,
index, &name);
if (strlen(name)) {
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] gpiolib: remove unneeded assignation
2015-07-07 20:22 [PATCH] gpiolib: remove unneeded assignation Laurent Navet
@ 2015-07-13 14:20 ` Alexandre Courbot
2015-07-16 13:51 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Alexandre Courbot @ 2015-07-13 14:20 UTC (permalink / raw)
To: Laurent Navet
Cc: Linus Walleij, linux-gpio@vger.kernel.org,
Linux Kernel Mailing List
On Wed, Jul 8, 2015 at 5:22 AM, Laurent Navet <laurent.navet@gmail.com> wrote:
> ret is assigned value from of_property_read_string_index but is
> overwritten before being used so remove it.
> Also fix coverity CID 1309759
You should probably have a line that says
Reported-by: coverity (CID 1309759)
As other similar patches do.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpiolib: remove unneeded assignation
2015-07-07 20:22 [PATCH] gpiolib: remove unneeded assignation Laurent Navet
2015-07-13 14:20 ` Alexandre Courbot
@ 2015-07-16 13:51 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2015-07-16 13:51 UTC (permalink / raw)
To: Laurent Navet
Cc: Alexandre Courbot, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
On Tue, Jul 7, 2015 at 10:22 PM, Laurent Navet <laurent.navet@gmail.com> wrote:
> ret is assigned value from of_property_read_string_index but is
> overwritten before being used so remove it.
> Also fix coverity CID 1309759
>
> Signed-off-by: Laurent Navet <laurent.navet@gmail.com>
Patch applied with Alex' suggested Reported-by tag.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-16 13:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-07 20:22 [PATCH] gpiolib: remove unneeded assignation Laurent Navet
2015-07-13 14:20 ` Alexandre Courbot
2015-07-16 13:51 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).