[PATCH 1/2] misc: ti-fpc202: remove unneeded direction check

[PATCH 1/2] misc: ti-fpc202: remove unneeded direction check

[Bartosz Golaszewski]

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

As of commit 92ac7de3175e3 ("gpiolib: don't allow setting values on input
lines"), the GPIO core makes sure values cannot be set on input lines.
Remove the unnecessary check.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
 drivers/misc/ti_fpc202.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/misc/ti_fpc202.c b/drivers/misc/ti_fpc202.c
index f7cde245ac95..ca415ef45cbe 100644
--- a/drivers/misc/ti_fpc202.c
+++ b/drivers/misc/ti_fpc202.c
@@ -125,9 +125,6 @@ static void fpc202_gpio_set(struct gpio_chip *chip, unsigned int offset,
 	int ret;
 	u8 val;
 
-	if (fpc202_gpio_get_dir(offset) == GPIO_LINE_DIRECTION_IN)
-		return;
-
 	ret = fpc202_read(priv, FPC202_REG_OUT_A_OUT_B_VAL);
 	if (ret < 0) {
 		dev_err(&priv->client->dev, "Failed to set GPIO %d value! err %d\n", offset, ret);
-- 
2.48.1

[PATCH 2/2] misc: ti-fpc202: use new GPIO line value setter callbacks

[Bartosz Golaszewski]

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
 drivers/misc/ti_fpc202.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/misc/ti_fpc202.c b/drivers/misc/ti_fpc202.c
index ca415ef45cbe..f84cae50e2c9 100644
--- a/drivers/misc/ti_fpc202.c
+++ b/drivers/misc/ti_fpc202.c
@@ -118,8 +118,8 @@ static void fpc202_set_enable(struct fpc202_priv *priv, int enable)
 	gpiod_set_value(priv->en_gpio, enable);
 }
 
-static void fpc202_gpio_set(struct gpio_chip *chip, unsigned int offset,
-			    int value)
+static int fpc202_gpio_set(struct gpio_chip *chip, unsigned int offset,
+			   int value)
 {
 	struct fpc202_priv *priv = gpiochip_get_data(chip);
 	int ret;
@@ -128,7 +128,7 @@ static void fpc202_gpio_set(struct gpio_chip *chip, unsigned int offset,
 	ret = fpc202_read(priv, FPC202_REG_OUT_A_OUT_B_VAL);
 	if (ret < 0) {
 		dev_err(&priv->client->dev, "Failed to set GPIO %d value! err %d\n", offset, ret);
-		return;
+		return ret;
 	}
 
 	val = (u8)ret;
@@ -138,7 +138,7 @@ static void fpc202_gpio_set(struct gpio_chip *chip, unsigned int offset,
 	else
 		val &= ~BIT(offset - FPC202_GPIO_P0_S0_OUT_A);
 
-	fpc202_write(priv, FPC202_REG_OUT_A_OUT_B_VAL, val);
+	return fpc202_write(priv, FPC202_REG_OUT_A_OUT_B_VAL, val);
 }
 
 static int fpc202_gpio_get(struct gpio_chip *chip, unsigned int offset)
@@ -333,7 +333,7 @@ static int fpc202_probe(struct i2c_client *client)
 	priv->gpio.base = -1;
 	priv->gpio.direction_input = fpc202_gpio_direction_input;
 	priv->gpio.direction_output = fpc202_gpio_direction_output;
-	priv->gpio.set = fpc202_gpio_set;
+	priv->gpio.set_rv = fpc202_gpio_set;
 	priv->gpio.get = fpc202_gpio_get;
 	priv->gpio.ngpio = FPC202_GPIO_COUNT;
 	priv->gpio.parent = dev;
-- 
2.48.1

Re: [PATCH 2/2] misc: ti-fpc202: use new GPIO line value setter callbacks

[Bartosz Golaszewski]

On Thu, Jul 17, 2025 at 3:04 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> struct gpio_chip now has callbacks for setting line values that return
> an integer, allowing to indicate failures. Convert the driver to using
> them.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---

Greg: this patch comes in late into the cycle but the driver in
question got merged for v6.16-rc1 despite the set() callback in struct
gpio_chip being already deprecated and it went below my radar. This is
one of the few remaining conversions and if we get it queued for
v6.17, we'll be able to complete it next release and drop legacy
callbacks. I know you're busy so if you could Ack it (and I hope I can
get a review from Romain and Linus), I'm more than happy to take it
through the GPIO tree to speed up the process.

Thanks,
Bartosz

Re: [PATCH 2/2] misc: ti-fpc202: use new GPIO line value setter callbacks

[Greg Kroah-Hartman]

On Thu, Jul 17, 2025 at 03:32:07PM +0200, Bartosz Golaszewski wrote:
> On Thu, Jul 17, 2025 at 3:04 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> >
> > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> >
> > struct gpio_chip now has callbacks for setting line values that return
> > an integer, allowing to indicate failures. Convert the driver to using
> > them.
> >
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > ---
> 
> Greg: this patch comes in late into the cycle but the driver in
> question got merged for v6.16-rc1 despite the set() callback in struct
> gpio_chip being already deprecated and it went below my radar. This is
> one of the few remaining conversions and if we get it queued for
> v6.17, we'll be able to complete it next release and drop legacy
> callbacks. I know you're busy so if you could Ack it (and I hope I can
> get a review from Romain and Linus), I'm more than happy to take it
> through the GPIO tree to speed up the process.

No worries, please take it through your tree, now acked.

greg k-h

Re: [PATCH 2/2] misc: ti-fpc202: use new GPIO line value setter callbacks

[Greg Kroah-Hartman]

On Thu, Jul 17, 2025 at 03:03:56PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> struct gpio_chip now has callbacks for setting line values that return
> an integer, allowing to indicate failures. Convert the driver to using
> them.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Re: [PATCH 2/2] misc: ti-fpc202: use new GPIO line value setter callbacks

[Romain Gantois]

[-- Attachment #1: Type: text/plain, Size: 2192 bytes --]

On Thursday, 17 July 2025 15:03:56 CEST Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> struct gpio_chip now has callbacks for setting line values that return
> an integer, allowing to indicate failures. Convert the driver to using
> them.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
>  drivers/misc/ti_fpc202.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/misc/ti_fpc202.c b/drivers/misc/ti_fpc202.c
> index ca415ef45cbe..f84cae50e2c9 100644
> --- a/drivers/misc/ti_fpc202.c
> +++ b/drivers/misc/ti_fpc202.c
> @@ -118,8 +118,8 @@ static void fpc202_set_enable(struct fpc202_priv *priv,
> int enable) gpiod_set_value(priv->en_gpio, enable);
>  }
> 
> -static void fpc202_gpio_set(struct gpio_chip *chip, unsigned int offset,
> -			    int value)
> +static int fpc202_gpio_set(struct gpio_chip *chip, unsigned int offset,
> +			   int value)
>  {
>  	struct fpc202_priv *priv = gpiochip_get_data(chip);
>  	int ret;
> @@ -128,7 +128,7 @@ static void fpc202_gpio_set(struct gpio_chip *chip,
> unsigned int offset, ret = fpc202_read(priv, FPC202_REG_OUT_A_OUT_B_VAL);
>  	if (ret < 0) {
>  		dev_err(&priv->client->dev, "Failed to set GPIO %d value! err 
%d\n",
> offset, ret); -		return;
> +		return ret;
>  	}
> 
>  	val = (u8)ret;
> @@ -138,7 +138,7 @@ static void fpc202_gpio_set(struct gpio_chip *chip,
> unsigned int offset, else
>  		val &= ~BIT(offset - FPC202_GPIO_P0_S0_OUT_A);
> 
> -	fpc202_write(priv, FPC202_REG_OUT_A_OUT_B_VAL, val);
> +	return fpc202_write(priv, FPC202_REG_OUT_A_OUT_B_VAL, val);
>  }
> 
>  static int fpc202_gpio_get(struct gpio_chip *chip, unsigned int offset)
> @@ -333,7 +333,7 @@ static int fpc202_probe(struct i2c_client *client)
>  	priv->gpio.base = -1;
>  	priv->gpio.direction_input = fpc202_gpio_direction_input;
>  	priv->gpio.direction_output = fpc202_gpio_direction_output;
> -	priv->gpio.set = fpc202_gpio_set;
> +	priv->gpio.set_rv = fpc202_gpio_set;
>  	priv->gpio.get = fpc202_gpio_get;
>  	priv->gpio.ngpio = FPC202_GPIO_COUNT;
>  	priv->gpio.parent = dev;

Reviewed-by: Romain Gantois <romain.gantois@bootlin.com>


[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH 1/2] misc: ti-fpc202: remove unneeded direction check

[Greg Kroah-Hartman]

On Thu, Jul 17, 2025 at 03:03:55PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> As of commit 92ac7de3175e3 ("gpiolib: don't allow setting values on input
> lines"), the GPIO core makes sure values cannot be set on input lines.
> Remove the unnecessary check.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Re: [PATCH 1/2] misc: ti-fpc202: remove unneeded direction check

[Romain Gantois]

[-- Attachment #1: Type: text/plain, Size: 1085 bytes --]

Hi Bartosz,

On Thursday, 17 July 2025 15:03:55 CEST Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> As of commit 92ac7de3175e3 ("gpiolib: don't allow setting values on input
> lines"), the GPIO core makes sure values cannot be set on input lines.
> Remove the unnecessary check.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
>  drivers/misc/ti_fpc202.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/misc/ti_fpc202.c b/drivers/misc/ti_fpc202.c
> index f7cde245ac95..ca415ef45cbe 100644
> --- a/drivers/misc/ti_fpc202.c
> +++ b/drivers/misc/ti_fpc202.c
> @@ -125,9 +125,6 @@ static void fpc202_gpio_set(struct gpio_chip *chip,
> unsigned int offset, int ret;
>  	u8 val;
> 
> -	if (fpc202_gpio_get_dir(offset) == GPIO_LINE_DIRECTION_IN)
> -		return;
> -
>  	ret = fpc202_read(priv, FPC202_REG_OUT_A_OUT_B_VAL);
>  	if (ret < 0) {
>  		dev_err(&priv->client->dev, "Failed to set GPIO %d value! err 
%d\n",
> offset, ret);

LGTM

Reviewed-by: Romain Gantois <romain.gantois@bootlin.com>


[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH 1/2] misc: ti-fpc202: remove unneeded direction check

[Bartosz Golaszewski]

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>


On Thu, 17 Jul 2025 15:03:55 +0200, Bartosz Golaszewski wrote:
> As of commit 92ac7de3175e3 ("gpiolib: don't allow setting values on input
> lines"), the GPIO core makes sure values cannot be set on input lines.
> Remove the unnecessary check.
> 
> 

Applied, thanks!

[1/2] misc: ti-fpc202: remove unneeded direction check
      https://git.kernel.org/brgl/linux/c/db7897ad60fd7d7bf471bc1c49e3d01fefadade3
[2/2] misc: ti-fpc202: use new GPIO line value setter callbacks
      https://git.kernel.org/brgl/linux/c/74896eae7e040e1b2a381efc8df0c839023dbf16

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>