linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Markus Pargmann <mpa@pengutronix.de>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "Alexandre Courbot" <gnurou@gmail.com>,
	"Arun Bharadwaj" <arun@gumstix.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Johan Hovold" <johan@kernel.org>,
	linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	kernel@pengutronix.de, "Markus Pargmann" <mpa@pengutronix.de>
Subject: [PATCH 3/6] gpiolib-of: Reuse 'line-name' from DT as gpio descriptor name
Date: Tue,  4 Aug 2015 11:23:20 +0200	[thread overview]
Message-ID: <1438680203-13432-4-git-send-email-mpa@pengutronix.de> (raw)
In-Reply-To: <1438680203-13432-1-git-send-email-mpa@pengutronix.de>

The DT describes gpios with subnodes. These subnodes can contain a
property 'line-name'. This information can be useful in other areas
where we want to identify a GPIO by its name.

This patch stores the line-name in the gpio descriptor.

Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
---
 drivers/gpio/gpiolib-of.c | 27 ++++++++++++++++++---------
 1 file changed, 18 insertions(+), 9 deletions(-)

diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c
index 41a4945b346e..fbf449a4120b 100644
--- a/drivers/gpio/gpiolib-of.c
+++ b/drivers/gpio/gpiolib-of.c
@@ -184,11 +184,6 @@ static struct gpio_desc *of_parse_gpio(struct device_node *np,
 		*dflags |= GPIOD_OUT_LOW;
 	else if (of_property_read_bool(np, "output-high"))
 		*dflags |= GPIOD_OUT_HIGH;
-	else {
-		pr_warn("GPIO line %d (%s): no hogging state specified, bailing out\n",
-			desc_to_gpio(gg_data.out_gpio), np->name);
-		return ERR_PTR(-EINVAL);
-	}
 
 	if (name && of_property_read_string(np, "line-name", name))
 		*name = np->name;
@@ -214,15 +209,29 @@ static void of_gpiochip_scan_gpios(struct gpio_chip *chip)
 	enum gpiod_flags dflags;
 
 	for_each_child_of_node(chip->of_node, np) {
-		if (!of_property_read_bool(np, "gpio-hog"))
-			continue;
+		struct gpio_desc *name_desc;
 
 		desc = of_parse_gpio(np, &name, &lflags, &dflags);
 		if (IS_ERR(desc))
 			continue;
 
-		if (gpiod_hog(desc, name, lflags, dflags))
-			continue;
+		name_desc = gpio_name_to_desc(name);
+		if (name_desc)
+			pr_warn("GPIO name collision for '%s' detected at GPIO line %d (%s)\n",
+				name, desc_to_gpio(desc), np->name);
+		else
+			desc->name = name;
+
+		if (of_property_read_bool(np, "gpio-hog")) {
+			if (!dflags) {
+				pr_warn("GPIO line %d (%s): no hogging state specified, bailing out\n",
+					desc_to_gpio(desc), np->name);
+				continue;
+			}
+
+			if (gpiod_hog(desc, name, lflags, dflags))
+				continue;
+		}
 	}
 }
 
-- 
2.1.4


  parent reply	other threads:[~2015-08-04  9:24 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-04  9:23 [PATCH 0/6] gpiolib: Add GPIO name support Markus Pargmann
2015-08-04  9:23 ` [PATCH 1/6] gpiolib-of: Rename gpio_hog functions to be generic Markus Pargmann
2015-08-10  9:29   ` Linus Walleij
2015-08-13 13:14     ` Markus Pargmann
2015-08-04  9:23 ` [PATCH 2/6] gpio: Introduce gpio descriptor 'name' Markus Pargmann
2015-08-10  9:37   ` Linus Walleij
2015-08-13 13:28     ` Markus Pargmann
2015-08-25 14:25       ` Linus Walleij
2015-08-04  9:23 ` Markus Pargmann [this message]
2015-08-10  9:38   ` [PATCH 3/6] gpiolib-of: Reuse 'line-name' from DT as gpio descriptor name Linus Walleij
2015-08-04  9:23 ` [PATCH 4/6] gpiolib-sysfs: Add gpio name parsing for sysfs export Markus Pargmann
2015-08-10  9:40   ` Linus Walleij
2015-08-04  9:23 ` [PATCH 5/6] gpiolib-sysfs: Show gpio-name in /sys/class/gpio/gpio*/name Markus Pargmann
2015-08-10  9:50   ` Linus Walleij
2015-08-13 13:43     ` Markus Pargmann
2015-09-23 22:20     ` Johan Hovold
2015-08-04  9:23 ` [PATCH 6/6] gpiolib: Add gpio name information to /sys/kernel/debug/gpio Markus Pargmann
2015-08-10 10:02   ` Linus Walleij
2015-08-17  7:29     ` Alexandre Courbot
2015-08-25 14:34       ` Linus Walleij
2015-08-04  9:25 ` [PATCH 0/6 v2] gpiolib: Add GPIO name support Markus Pargmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1438680203-13432-4-git-send-email-mpa@pengutronix.de \
    --to=mpa@pengutronix.de \
    --cc=arun@gumstix.com \
    --cc=gnurou@gmail.com \
    --cc=johan@kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).