* [PATCH 1/2] pinctrl: baytrail: Drop FSF mailing address @ 2015-08-04 12:03 Mika Westerberg 2015-08-04 12:03 ` [PATCH 2/2] pinctrl: baytrail: Serialize all register access Mika Westerberg 2015-08-13 12:25 ` [PATCH 1/2] pinctrl: baytrail: Drop FSF mailing address Linus Walleij 0 siblings, 2 replies; 6+ messages in thread From: Mika Westerberg @ 2015-08-04 12:03 UTC (permalink / raw) To: Linus Walleij Cc: Mathias Nyman, Heikki Krogerus, Mika Westerberg, linux-gpio, linux-kernel The FSF address is already mentioned in the COPYING file. No need to duplicate that information to individual files. Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> --- drivers/pinctrl/intel/pinctrl-baytrail.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/pinctrl/intel/pinctrl-baytrail.c b/drivers/pinctrl/intel/pinctrl-baytrail.c index 2062c224e32f..4b82381c9a57 100644 --- a/drivers/pinctrl/intel/pinctrl-baytrail.c +++ b/drivers/pinctrl/intel/pinctrl-baytrail.c @@ -12,11 +12,6 @@ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for * more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include <linux/kernel.h> -- 2.4.6 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] pinctrl: baytrail: Serialize all register access 2015-08-04 12:03 [PATCH 1/2] pinctrl: baytrail: Drop FSF mailing address Mika Westerberg @ 2015-08-04 12:03 ` Mika Westerberg 2015-08-13 12:26 ` Linus Walleij 2015-10-30 14:48 ` Lucas De Marchi 2015-08-13 12:25 ` [PATCH 1/2] pinctrl: baytrail: Drop FSF mailing address Linus Walleij 1 sibling, 2 replies; 6+ messages in thread From: Mika Westerberg @ 2015-08-04 12:03 UTC (permalink / raw) To: Linus Walleij Cc: Mathias Nyman, Heikki Krogerus, Mika Westerberg, linux-gpio, linux-kernel There is a hardware issue in Intel Baytrail where concurrent GPIO register access might result reads of 0xffffffff and writes might get dropped completely. Prevent this from happening by taking the serializing lock in all places where it is possible that more than one thread might be accessing the hardware concurrently. Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> --- drivers/pinctrl/intel/pinctrl-baytrail.c | 21 ++++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/drivers/pinctrl/intel/pinctrl-baytrail.c b/drivers/pinctrl/intel/pinctrl-baytrail.c index 4b82381c9a57..f80a1bee6981 100644 --- a/drivers/pinctrl/intel/pinctrl-baytrail.c +++ b/drivers/pinctrl/intel/pinctrl-baytrail.c @@ -196,6 +196,9 @@ static int byt_gpio_request(struct gpio_chip *chip, unsigned offset) struct byt_gpio *vg = to_byt_gpio(chip); void __iomem *reg = byt_gpio_reg(chip, offset, BYT_CONF0_REG); u32 value, gpio_mux; + unsigned long flags; + + spin_lock_irqsave(&vg->lock, flags); /* * In most cases, func pin mux 000 means GPIO function. @@ -209,18 +212,16 @@ static int byt_gpio_request(struct gpio_chip *chip, unsigned offset) value = readl(reg) & BYT_PIN_MUX; gpio_mux = byt_get_gpio_mux(vg, offset); if (WARN_ON(gpio_mux != value)) { - unsigned long flags; - - spin_lock_irqsave(&vg->lock, flags); value = readl(reg) & ~BYT_PIN_MUX; value |= gpio_mux; writel(value, reg); - spin_unlock_irqrestore(&vg->lock, flags); dev_warn(&vg->pdev->dev, "pin %u forcibly re-configured as GPIO\n", offset); } + spin_unlock_irqrestore(&vg->lock, flags); + pm_runtime_get(&vg->pdev->dev); return 0; @@ -272,7 +273,15 @@ static int byt_irq_type(struct irq_data *d, unsigned type) static int byt_gpio_get(struct gpio_chip *chip, unsigned offset) { void __iomem *reg = byt_gpio_reg(chip, offset, BYT_VAL_REG); - return readl(reg) & BYT_LEVEL; + struct byt_gpio *vg = to_byt_gpio(chip); + unsigned long flags; + u32 val; + + spin_lock_irqsave(&vg->lock, flags); + val = readl(reg); + spin_unlock_irqrestore(&vg->lock, flags); + + return val & BYT_LEVEL; } static void byt_gpio_set(struct gpio_chip *chip, unsigned offset, int value) @@ -445,8 +454,10 @@ static void byt_irq_ack(struct irq_data *d) unsigned offset = irqd_to_hwirq(d); void __iomem *reg; + spin_lock(&vg->lock); reg = byt_gpio_reg(&vg->chip, offset, BYT_INT_STAT_REG); writel(BIT(offset % 32), reg); + spin_unlock(&vg->lock); } static void byt_irq_unmask(struct irq_data *d) -- 2.4.6 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] pinctrl: baytrail: Serialize all register access 2015-08-04 12:03 ` [PATCH 2/2] pinctrl: baytrail: Serialize all register access Mika Westerberg @ 2015-08-13 12:26 ` Linus Walleij 2015-10-30 14:48 ` Lucas De Marchi 1 sibling, 0 replies; 6+ messages in thread From: Linus Walleij @ 2015-08-13 12:26 UTC (permalink / raw) To: Mika Westerberg Cc: Mathias Nyman, Heikki Krogerus, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org On Tue, Aug 4, 2015 at 2:03 PM, Mika Westerberg <mika.westerberg@linux.intel.com> wrote: > There is a hardware issue in Intel Baytrail where concurrent GPIO register > access might result reads of 0xffffffff and writes might get dropped > completely. > > Prevent this from happening by taking the serializing lock in all places > where it is possible that more than one thread might be accessing the > hardware concurrently. > > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> Patch applied. Same comment here about the fastpath and the RT raw spinlocks. Yours, Linus Walleij ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] pinctrl: baytrail: Serialize all register access 2015-08-04 12:03 ` [PATCH 2/2] pinctrl: baytrail: Serialize all register access Mika Westerberg 2015-08-13 12:26 ` Linus Walleij @ 2015-10-30 14:48 ` Lucas De Marchi 2015-10-30 15:26 ` Greg KH 1 sibling, 1 reply; 6+ messages in thread From: Lucas De Marchi @ 2015-10-30 14:48 UTC (permalink / raw) To: Mika Westerberg Cc: Linus Walleij, Mathias Nyman, Heikki Krogerus, linux-gpio@vger.kernel.org, lkml, Greg KH Hi Mika and Linus, CC'ing Greg. On Tue, Aug 4, 2015 at 9:03 AM, Mika Westerberg <mika.westerberg@linux.intel.com> wrote: > There is a hardware issue in Intel Baytrail where concurrent GPIO register > access might result reads of 0xffffffff and writes might get dropped > completely. > > Prevent this from happening by taking the serializing lock in all places > where it is possible that more than one thread might be accessing the > hardware concurrently. > > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> > --- Now that this is on 4.2, can we get it on stable branches? I was hitting this bug for some time on MinnowBoard Max and this week I had some time to take a look on how to fix it. Good timing, it had already been fixed. Applying this patch the issue is gone on top of 4.1.12. I'm using these patches from Linus Torvalds' tree: 39ce815 pinctrl: baytrail: Serialize all register access 78e1c89 pinctrl: baytrail: Use raw_spinlock for locking The ones to Cherryview could be sent too but I couldn't test them. Leaving the patch below for reference. thanks Lucas De Marchi > drivers/pinctrl/intel/pinctrl-baytrail.c | 21 ++++++++++++++++----- > 1 file changed, 16 insertions(+), 5 deletions(-) > > diff --git a/drivers/pinctrl/intel/pinctrl-baytrail.c b/drivers/pinctrl/intel/pinctrl-baytrail.c > index 4b82381c9a57..f80a1bee6981 100644 > --- a/drivers/pinctrl/intel/pinctrl-baytrail.c > +++ b/drivers/pinctrl/intel/pinctrl-baytrail.c > @@ -196,6 +196,9 @@ static int byt_gpio_request(struct gpio_chip *chip, unsigned offset) > struct byt_gpio *vg = to_byt_gpio(chip); > void __iomem *reg = byt_gpio_reg(chip, offset, BYT_CONF0_REG); > u32 value, gpio_mux; > + unsigned long flags; > + > + spin_lock_irqsave(&vg->lock, flags); > > /* > * In most cases, func pin mux 000 means GPIO function. > @@ -209,18 +212,16 @@ static int byt_gpio_request(struct gpio_chip *chip, unsigned offset) > value = readl(reg) & BYT_PIN_MUX; > gpio_mux = byt_get_gpio_mux(vg, offset); > if (WARN_ON(gpio_mux != value)) { > - unsigned long flags; > - > - spin_lock_irqsave(&vg->lock, flags); > value = readl(reg) & ~BYT_PIN_MUX; > value |= gpio_mux; > writel(value, reg); > - spin_unlock_irqrestore(&vg->lock, flags); > > dev_warn(&vg->pdev->dev, > "pin %u forcibly re-configured as GPIO\n", offset); > } > > + spin_unlock_irqrestore(&vg->lock, flags); > + > pm_runtime_get(&vg->pdev->dev); > > return 0; > @@ -272,7 +273,15 @@ static int byt_irq_type(struct irq_data *d, unsigned type) > static int byt_gpio_get(struct gpio_chip *chip, unsigned offset) > { > void __iomem *reg = byt_gpio_reg(chip, offset, BYT_VAL_REG); > - return readl(reg) & BYT_LEVEL; > + struct byt_gpio *vg = to_byt_gpio(chip); > + unsigned long flags; > + u32 val; > + > + spin_lock_irqsave(&vg->lock, flags); > + val = readl(reg); > + spin_unlock_irqrestore(&vg->lock, flags); > + > + return val & BYT_LEVEL; > } > > static void byt_gpio_set(struct gpio_chip *chip, unsigned offset, int value) > @@ -445,8 +454,10 @@ static void byt_irq_ack(struct irq_data *d) > unsigned offset = irqd_to_hwirq(d); > void __iomem *reg; > > + spin_lock(&vg->lock); > reg = byt_gpio_reg(&vg->chip, offset, BYT_INT_STAT_REG); > writel(BIT(offset % 32), reg); > + spin_unlock(&vg->lock); > } > > static void byt_irq_unmask(struct irq_data *d) > -- > 2.4.6 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- Lucas De Marchi ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] pinctrl: baytrail: Serialize all register access 2015-10-30 14:48 ` Lucas De Marchi @ 2015-10-30 15:26 ` Greg KH 0 siblings, 0 replies; 6+ messages in thread From: Greg KH @ 2015-10-30 15:26 UTC (permalink / raw) To: Lucas De Marchi Cc: Mika Westerberg, Linus Walleij, Mathias Nyman, Heikki Krogerus, linux-gpio@vger.kernel.org, lkml On Fri, Oct 30, 2015 at 12:48:38PM -0200, Lucas De Marchi wrote: > Hi Mika and Linus, > > CC'ing Greg. > > On Tue, Aug 4, 2015 at 9:03 AM, Mika Westerberg > <mika.westerberg@linux.intel.com> wrote: > > There is a hardware issue in Intel Baytrail where concurrent GPIO register > > access might result reads of 0xffffffff and writes might get dropped > > completely. > > > > Prevent this from happening by taking the serializing lock in all places > > where it is possible that more than one thread might be accessing the > > hardware concurrently. > > > > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> > > --- > > Now that this is on 4.2, can we get it on stable branches? I was > hitting this bug for some time on MinnowBoard Max and this week I had > some time to take a look on how to fix it. Good timing, it had already > been fixed. Applying this patch the issue is gone on top of 4.1.12. > > I'm using these patches from Linus Torvalds' tree: > 39ce815 pinctrl: baytrail: Serialize all register access > 78e1c89 pinctrl: baytrail: Use raw_spinlock for locking > > > The ones to Cherryview could be sent too but I couldn't test them. > > Leaving the patch below for reference. <formletter> This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read Documentation/stable_kernel_rules.txt for how to do this properly. </formletter> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] pinctrl: baytrail: Drop FSF mailing address 2015-08-04 12:03 [PATCH 1/2] pinctrl: baytrail: Drop FSF mailing address Mika Westerberg 2015-08-04 12:03 ` [PATCH 2/2] pinctrl: baytrail: Serialize all register access Mika Westerberg @ 2015-08-13 12:25 ` Linus Walleij 1 sibling, 0 replies; 6+ messages in thread From: Linus Walleij @ 2015-08-13 12:25 UTC (permalink / raw) To: Mika Westerberg Cc: Mathias Nyman, Heikki Krogerus, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org On Tue, Aug 4, 2015 at 2:03 PM, Mika Westerberg <mika.westerberg@linux.intel.com> wrote: > The FSF address is already mentioned in the COPYING file. No need to > duplicate that information to individual files. > > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> Patch applied. Yours, Linus Walleij ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-10-30 15:27 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-08-04 12:03 [PATCH 1/2] pinctrl: baytrail: Drop FSF mailing address Mika Westerberg 2015-08-04 12:03 ` [PATCH 2/2] pinctrl: baytrail: Serialize all register access Mika Westerberg 2015-08-13 12:26 ` Linus Walleij 2015-10-30 14:48 ` Lucas De Marchi 2015-10-30 15:26 ` Greg KH 2015-08-13 12:25 ` [PATCH 1/2] pinctrl: baytrail: Drop FSF mailing address Linus Walleij
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).