From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Tony Lindgren <tony@atomide.com>,
Austin Schuh <austin@peloton-tech.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Santosh Shilimkar <ssantosh@kernel.org>
Subject: [PATCH] gpio: make GPIO_OMAP bool instead of tristate
Date: Tue, 6 Oct 2015 17:31:11 +0530 [thread overview]
Message-ID: <1444132871-25798-1-git-send-email-sudipm.mukherjee@gmail.com> (raw)
While building arm allmodconfig the build fails with the error:
ERROR: "handle_bad_irq" [drivers/gpio/gpio-omap.ko] undefined!
The build breaks as handle_bad_irq is not exported for module use.
Fixes: 450fa54cfd66 ("gpio: omap: convert to use generic irq handler")
Cc: Tony Lindgren <tony@atomide.com>
Cc: Austin Schuh <austin@peloton-tech.com>
Cc: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: Santosh Shilimkar <ssantosh@kernel.org>
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
Same problem for pinctrl was fixed by
5ba341604a054294aeb812603349bba024d716ee
And for your reference:
https://lkml.org/lkml/2014/2/25/278
drivers/gpio/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 63000b1..d910fd1 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -330,7 +330,7 @@ config GPIO_OCTEON
family of SOCs.
config GPIO_OMAP
- tristate "TI OMAP GPIO support" if ARCH_OMAP2PLUS || COMPILE_TEST
+ bool "TI OMAP GPIO support" if ARCH_OMAP2PLUS || COMPILE_TEST
default y if ARCH_OMAP
depends on ARM
select GENERIC_IRQ_CHIP
--
1.9.1
next reply other threads:[~2015-10-06 12:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-06 12:01 Sudip Mukherjee [this message]
2015-10-06 20:45 ` [PATCH] gpio: make GPIO_OMAP bool instead of tristate Grygorii Strashko
2015-10-07 7:27 ` Sudip Mukherjee
2015-10-07 19:19 ` Grygorii Strashko
2015-10-16 15:08 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444132871-25798-1-git-send-email-sudipm.mukherjee@gmail.com \
--to=sudipm.mukherjee@gmail.com \
--cc=austin@peloton-tech.com \
--cc=gnurou@gmail.com \
--cc=grygorii.strashko@ti.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ssantosh@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).