the needless loop?

the needless loop?

[Shevchenko, Andriy]

Hi!

Catch such code in pinconf.c

         for (j = 0; j < map->data.configs.num_configs; j++) {
                 if (!strcmp(map->data.configs.group_or_pin,
                                 dbg->pin_name)) {
                         /* We found the right pin / state */
                         found = map;
                         break;
                 }
         }

I do not get how the result of strcmp() would be different during the
loop. Can you elaborate?

-- 
Andy Shevchenko <andriy.shevchenko@intel.com>
Intel Finland Oy
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki 
Business Identity Code: 0357606 - 4 
Domiciled in Helsinki 

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

Re: the needless loop?

[Linus Walleij]

On Wed, Oct 21, 2015 at 6:45 PM, Shevchenko, Andriy
<andriy.shevchenko@intel.com> wrote:

> Catch such code in pinconf.c
>
>          for (j = 0; j < map->data.configs.num_configs; j++) {
>                  if (!strcmp(map->data.configs.group_or_pin,
>                                  dbg->pin_name)) {
>                          /* We found the right pin / state */
>                          found = map;
>                          break;
>                  }
>          }
>
> I do not get how the result of strcmp() would be different during the
> loop. Can you elaborate?

As you can see from git blame Laurent Meunier wrote this code,
(commit f07512e615dd8) so let's
ask him. I suspect a simple copy/paste error? Laurent?

Yours,
Linus Walleij

RE: the needless loop?

[Laurent MEUNIER]

Hi Linus, Andriy,

> On Wed, Oct 21, 2015 at 6:45 PM, Shevchenko, Andriy
> <andriy.shevchenko@intel.com> wrote:
> 
> > Catch such code in pinconf.c
> >
> >          for (j = 0; j < map->data.configs.num_configs; j++) {
> >                  if (!strcmp(map->data.configs.group_or_pin,
> >                                  dbg->pin_name)) {
> >                          /* We found the right pin / state */
> >                          found = map;
> >                          break;
> >                  }
> >          }
> >
> > I do not get how the result of strcmp() would be different during the
> > loop. Can you elaborate?
>
> As you can see from git blame Laurent Meunier wrote this code, (commit
> f07512e615dd8) so let's ask him. I suspect a simple copy/paste error?
> Laurent?

Indeed obviously a copy / paste error I did 
The loop shall be removed ... Has someone already any plan to send the fix ? 

Laurent

> Yours,
> Linus Walleij

Re: the needless loop?

[Shevchenko, Andriy]

On Wed, 2015-10-28 at 10:07 +0000, Laurent MEUNIER wrote:
> Hi Linus, Andriy,
> 
> > On Wed, Oct 21, 2015 at 6:45 PM, Shevchenko, Andriy
> > <andriy.shevchenko@intel.com> wrote:
> > 
> > > Catch such code in pinconf.c
> > > 
> > >          for (j = 0; j < map->data.configs.num_configs; j++) {
> > >                  if (!strcmp(map->data.configs.group_or_pin,
> > >                                  dbg->pin_name)) {
> > >                          /* We found the right pin / state */
> > >                          found = map;
> > >                          break;
> > >                  }
> > >          }
> > > 
> > > I do not get how the result of strcmp() would be different during
> > > the
> > > loop. Can you elaborate?
> > 
> > As you can see from git blame Laurent Meunier wrote this code,
> > (commit
> > f07512e615dd8) so let's ask him. I suspect a simple copy/paste
> > error?
> > Laurent?
> 
> Indeed obviously a copy / paste error I did 
> The loop shall be removed ... Has someone already any plan to send
> the fix ? 

Not me, too busy with other stuff (https://lkml.org/lkml/2015/10/27/451
)

> 
> Laurent
> 
> > Yours,
> > Linus Walleij

-- 
Andy Shevchenko <andriy.shevchenko@intel.com>
Intel Finland Oy
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki 
Business Identity Code: 0357606 - 4 
Domiciled in Helsinki 

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

RE: the needless loop?

[Laurent MEUNIER]

> > Indeed obviously a copy / paste error I did The loop shall be removed
> > ... Has someone already any plan to send the fix ?
> 
> Not me, too busy with other stuff (https://lkml.org/lkml/2015/10/27/451
> )

Ok sure - I will do so 
Laurent

> >
> > Laurent
> >
> > > Yours,
> > > Linus Walleij
> 
> --
> Andy Shevchenko <andriy.shevchenko@intel.com> Intel Finland Oy
> ---------------------------------------------------------------------
> Intel Finland Oy
> Registered Address: PL 281, 00181 Helsinki Business Identity Code: 0357606 -
> 4 Domiciled in Helsinki
> 
> This e-mail and any attachments may contain confidential material for the
> sole use of the intended recipient(s). Any review or distribution by others is
> strictly prohibited. If you are not the intended recipient, please contact the
> sender and delete all copies.