* [PATCH V3] pinctrl: pinconf: remove needless loop
@ 2015-10-30 14:15 Laurent Meunier
2015-10-31 21:07 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Laurent Meunier @ 2015-10-30 14:15 UTC (permalink / raw)
To: linux-gpio; +Cc: linus.walleij, andriy.shevchenko, Laurent Meunier
This removes a needless loop which was caught in pinconf.c.
Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Laurent Meunier <laurent.meunier@st.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/pinctrl/pinconf.c | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/pinctrl/pinconf.c b/drivers/pinctrl/pinconf.c
index 29a7bb1..4dd7722 100644
--- a/drivers/pinctrl/pinconf.c
+++ b/drivers/pinctrl/pinconf.c
@@ -411,7 +411,7 @@ static int pinconf_dbg_config_print(struct seq_file *s, void *d)
const struct pinctrl_map *found = NULL;
struct pinctrl_dev *pctldev;
struct dbg_cfg *dbg = &pinconf_dbg_conf;
- int i, j;
+ int i;
mutex_lock(&pinctrl_maps_mutex);
@@ -424,13 +424,10 @@ static int pinconf_dbg_config_print(struct seq_file *s, void *d)
if (strcmp(map->name, dbg->state_name))
continue;
- for (j = 0; j < map->data.configs.num_configs; j++) {
- if (!strcmp(map->data.configs.group_or_pin,
- dbg->pin_name)) {
- /* We found the right pin / state */
- found = map;
- break;
- }
+ if (!strcmp(map->data.configs.group_or_pin, dbg->pin_name)) {
+ /* We found the right pin */
+ found = map;
+ break;
}
}
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH V3] pinctrl: pinconf: remove needless loop
2015-10-30 14:15 [PATCH V3] pinctrl: pinconf: remove needless loop Laurent Meunier
@ 2015-10-31 21:07 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2015-10-31 21:07 UTC (permalink / raw)
To: Laurent Meunier; +Cc: linux-gpio@vger.kernel.org, Andriy Shevchenko
On Fri, Oct 30, 2015 at 3:15 PM, Laurent Meunier <laurent.meunier@st.com> wrote:
> This removes a needless loop which was caught in pinconf.c.
>
> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Laurent Meunier <laurent.meunier@st.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-31 21:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-30 14:15 [PATCH V3] pinctrl: pinconf: remove needless loop Laurent Meunier
2015-10-31 21:07 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).