From: LABBE Corentin <clabbe.montjoie@gmail.com>
To: gnurou@gmail.com, linus.walleij@linaro.org
Cc: LABBE Corentin <clabbe.montjoie@gmail.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/3] gpio: syscon: fix a possible NULL dereference
Date: Wed, 11 Nov 2015 21:27:35 +0100 [thread overview]
Message-ID: <1447273657-1668-2-git-send-email-clabbe.montjoie@gmail.com> (raw)
In-Reply-To: <1447273657-1668-1-git-send-email-clabbe.montjoie@gmail.com>
of_match_device could return NULL, and so cause a NULL pointer
dereference later at line 199:
priv->flags = of_id->data;
Reported-by: coverity (CID 1324140)
Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
---
drivers/gpio/gpio-syscon.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-syscon.c b/drivers/gpio/gpio-syscon.c
index 045a952..7b25fdf 100644
--- a/drivers/gpio/gpio-syscon.c
+++ b/drivers/gpio/gpio-syscon.c
@@ -187,11 +187,15 @@ MODULE_DEVICE_TABLE(of, syscon_gpio_ids);
static int syscon_gpio_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
- const struct of_device_id *of_id = of_match_device(syscon_gpio_ids, dev);
+ const struct of_device_id *of_id;
struct syscon_gpio_priv *priv;
struct device_node *np = dev->of_node;
int ret;
+ of_id = of_match_device(syscon_gpio_ids, dev);
+ if (!of_id)
+ return -ENODEV;
+
priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
if (!priv)
return -ENOMEM;
--
2.4.10
next prev parent reply other threads:[~2015-11-11 20:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-11 20:27 [PATCH 1/3] gpio: 74xx: fix a possible NULL dereference LABBE Corentin
2015-11-11 20:27 ` LABBE Corentin [this message]
2015-11-17 13:39 ` [PATCH 2/3] gpio: syscon: " Linus Walleij
2015-11-11 20:27 ` [PATCH 3/3] gpio: palmas: " LABBE Corentin
2015-11-17 13:41 ` Linus Walleij
2015-11-17 13:37 ` [PATCH 1/3] gpio: 74xx: " Linus Walleij
2015-11-20 9:22 ` Geert Uytterhoeven
2015-11-30 12:08 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447273657-1668-2-git-send-email-clabbe.montjoie@gmail.com \
--to=clabbe.montjoie@gmail.com \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).