* [PATCH RFT] gpio: ath79: Fix the logic to clear offset bit of AR71XX_GPIO_REG_OE register
@ 2015-12-08 15:01 Axel Lin
2015-12-09 10:19 ` Alban
2015-12-11 18:13 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2015-12-08 15:01 UTC (permalink / raw)
To: Linus Walleij, Alexandre Courbot; +Cc: Alban Bedel, linux-gpio
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/gpio/gpio-ath79.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-ath79.c b/drivers/gpio/gpio-ath79.c
index e5827a5..5eaea8b 100644
--- a/drivers/gpio/gpio-ath79.c
+++ b/drivers/gpio/gpio-ath79.c
@@ -113,7 +113,7 @@ static int ar934x_gpio_direction_output(struct gpio_chip *chip, unsigned offset,
__raw_writel(BIT(offset), ctrl->base + AR71XX_GPIO_REG_CLEAR);
__raw_writel(
- __raw_readl(ctrl->base + AR71XX_GPIO_REG_OE) & BIT(offset),
+ __raw_readl(ctrl->base + AR71XX_GPIO_REG_OE) & ~BIT(offset),
ctrl->base + AR71XX_GPIO_REG_OE);
spin_unlock_irqrestore(&ctrl->lock, flags);
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH RFT] gpio: ath79: Fix the logic to clear offset bit of AR71XX_GPIO_REG_OE register
2015-12-08 15:01 [PATCH RFT] gpio: ath79: Fix the logic to clear offset bit of AR71XX_GPIO_REG_OE register Axel Lin
@ 2015-12-09 10:19 ` Alban
2015-12-11 18:13 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Alban @ 2015-12-09 10:19 UTC (permalink / raw)
To: Axel Lin; +Cc: Alban, Linus Walleij, Alexandre Courbot, linux-gpio
On Tue, 08 Dec 2015 23:01:07 +0800
Axel Lin <axel.lin@ingics.com> wrote:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Alban Bedel <albeu@free.fr>
> ---
> drivers/gpio/gpio-ath79.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-ath79.c b/drivers/gpio/gpio-ath79.c
> index e5827a5..5eaea8b 100644
> --- a/drivers/gpio/gpio-ath79.c
> +++ b/drivers/gpio/gpio-ath79.c
> @@ -113,7 +113,7 @@ static int ar934x_gpio_direction_output(struct gpio_chip *chip, unsigned offset,
> __raw_writel(BIT(offset), ctrl->base + AR71XX_GPIO_REG_CLEAR);
>
> __raw_writel(
> - __raw_readl(ctrl->base + AR71XX_GPIO_REG_OE) & BIT(offset),
> + __raw_readl(ctrl->base + AR71XX_GPIO_REG_OE) & ~BIT(offset),
> ctrl->base + AR71XX_GPIO_REG_OE);
>
> spin_unlock_irqrestore(&ctrl->lock, flags);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH RFT] gpio: ath79: Fix the logic to clear offset bit of AR71XX_GPIO_REG_OE register
2015-12-08 15:01 [PATCH RFT] gpio: ath79: Fix the logic to clear offset bit of AR71XX_GPIO_REG_OE register Axel Lin
2015-12-09 10:19 ` Alban
@ 2015-12-11 18:13 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2015-12-11 18:13 UTC (permalink / raw)
To: Axel Lin; +Cc: Alexandre Courbot, Alban Bedel, linux-gpio@vger.kernel.org
On Tue, Dec 8, 2015 at 4:01 PM, Axel Lin <axel.lin@ingics.com> wrote:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Patch applied for fixes with Alban's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-12-11 18:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-08 15:01 [PATCH RFT] gpio: ath79: Fix the logic to clear offset bit of AR71XX_GPIO_REG_OE register Axel Lin
2015-12-09 10:19 ` Alban
2015-12-11 18:13 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).