[PATCH 133/182] blackfin: extgpio: switch to gpiochip_add_data()

[PATCH 133/182] blackfin: extgpio: switch to gpiochip_add_data()

[Linus Walleij]

We're planning to remove the gpiochip_add() function to swith
to gpiochip_add_data() with NULL for data argument.

Cc: Sonic Zhang <sonic.zhang@analog.com>
Cc: Steven Miao <realmz6@gmail.com>
Cc: adi-buildroot-devel@lists.sourceforge.net
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
Blackfin maintainers: please ACK this so I can take it through
the GPIO tree.

BTW: consider cleaning this up and moving it to drivers/gpio
at some point. Also GPIO drivers should be including
to not knowing how <asm/gpio.h> is thought out. But please abstract
it out if you find the time.
---
 arch/blackfin/mach-bf538/ext-gpio.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/blackfin/mach-bf538/ext-gpio.c b/arch/blackfin/mach-bf538/ext-gpio.c
index 471a9b184d5b..c878b57d29aa 100644
--- a/arch/blackfin/mach-bf538/ext-gpio.c
+++ b/arch/blackfin/mach-bf538/ext-gpio.c
@@ -116,9 +116,9 @@ static struct gpio_chip bf538_porte_chip = {
 
 static int __init bf538_extgpio_setup(void)
 {
-	return gpiochip_add(&bf538_portc_chip) |
-		gpiochip_add(&bf538_portd_chip) |
-		gpiochip_add(&bf538_porte_chip);
+	return gpiochip_add_data(&bf538_portc_chip, NULL) |
+		gpiochip_add_data(&bf538_portd_chip, NULL) |
+		gpiochip_add_data(&bf538_porte_chip, NULL);
 }
 arch_initcall(bf538_extgpio_setup);
 
-- 
2.4.3

Re: [PATCH 133/182] blackfin: extgpio: switch to gpiochip_add_data()

[Sonic Zhang]

Acked-by: Sonic Zhang <sonic.zhang@analog.com>

On Wed, Dec 9, 2015 at 9:37 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
> We're planning to remove the gpiochip_add() function to swith
> to gpiochip_add_data() with NULL for data argument.
>
> Cc: Sonic Zhang <sonic.zhang@analog.com>
> Cc: Steven Miao <realmz6@gmail.com>
> Cc: adi-buildroot-devel@lists.sourceforge.net
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> Blackfin maintainers: please ACK this so I can take it through
> the GPIO tree.
>
> BTW: consider cleaning this up and moving it to drivers/gpio
> at some point. Also GPIO drivers should be including
> to not knowing how <asm/gpio.h> is thought out. But please abstract
> it out if you find the time.
> ---
>  arch/blackfin/mach-bf538/ext-gpio.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/blackfin/mach-bf538/ext-gpio.c b/arch/blackfin/mach-bf538/ext-gpio.c
> index 471a9b184d5b..c878b57d29aa 100644
> --- a/arch/blackfin/mach-bf538/ext-gpio.c
> +++ b/arch/blackfin/mach-bf538/ext-gpio.c
> @@ -116,9 +116,9 @@ static struct gpio_chip bf538_porte_chip = {
>
>  static int __init bf538_extgpio_setup(void)
>  {
> -       return gpiochip_add(&bf538_portc_chip) |
> -               gpiochip_add(&bf538_portd_chip) |
> -               gpiochip_add(&bf538_porte_chip);
> +       return gpiochip_add_data(&bf538_portc_chip, NULL) |
> +               gpiochip_add_data(&bf538_portd_chip, NULL) |
> +               gpiochip_add_data(&bf538_porte_chip, NULL);
>  }
>  arch_initcall(bf538_extgpio_setup);
>
> --
> 2.4.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html