From: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org, Johan Hovold <johan@kernel.org>,
Alexandre Courbot <acourbot@nvidia.com>,
Michael Welling <mwelling@ieee.org>,
Markus Pargmann <mpa@pengutronix.de>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH 014/182] gpio: arizona: use gpiochip data pointer
Date: Wed, 9 Dec 2015 13:42:39 +0000 [thread overview]
Message-ID: <1449668559.17838.1.camel@rf-debian.wolfsonmicro.main> (raw)
In-Reply-To: <1449666878-30404-1-git-send-email-linus.walleij@linaro.org>
On Wed, 2015-12-09 at 14:14 +0100, Linus Walleij wrote:
> This makes the driver use the data pointer added to the gpio_chip
> to store a pointer to the state container instead of relying on
> container_of().
>
> Cc: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
> Cc: Mark Brown <broonie@kernel.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/gpio/gpio-arizona.c | 15 +++++----------
> 1 file changed, 5 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpio/gpio-arizona.c b/drivers/gpio/gpio-arizona.c
> index 412d131b513d..c729fee1dcdf 100644
> --- a/drivers/gpio/gpio-arizona.c
> +++ b/drivers/gpio/gpio-arizona.c
> @@ -28,14 +28,9 @@ struct arizona_gpio {
> struct gpio_chip gpio_chip;
> };
>
> -static inline struct arizona_gpio *to_arizona_gpio(struct gpio_chip *chip)
> -{
> - return container_of(chip, struct arizona_gpio, gpio_chip);
> -}
> -
> static int arizona_gpio_direction_in(struct gpio_chip *chip, unsigned offset)
> {
> - struct arizona_gpio *arizona_gpio = to_arizona_gpio(chip);
> + struct arizona_gpio *arizona_gpio = gpiochip_get_data(chip);
> struct arizona *arizona = arizona_gpio->arizona;
>
> return regmap_update_bits(arizona->regmap, ARIZONA_GPIO1_CTRL + offset,
> @@ -44,7 +39,7 @@ static int arizona_gpio_direction_in(struct gpio_chip *chip, unsigned offset)
>
> static int arizona_gpio_get(struct gpio_chip *chip, unsigned offset)
> {
> - struct arizona_gpio *arizona_gpio = to_arizona_gpio(chip);
> + struct arizona_gpio *arizona_gpio = gpiochip_get_data(chip);
> struct arizona *arizona = arizona_gpio->arizona;
> unsigned int val;
> int ret;
> @@ -62,7 +57,7 @@ static int arizona_gpio_get(struct gpio_chip *chip, unsigned offset)
> static int arizona_gpio_direction_out(struct gpio_chip *chip,
> unsigned offset, int value)
> {
> - struct arizona_gpio *arizona_gpio = to_arizona_gpio(chip);
> + struct arizona_gpio *arizona_gpio = gpiochip_get_data(chip);
> struct arizona *arizona = arizona_gpio->arizona;
>
> if (value)
> @@ -74,7 +69,7 @@ static int arizona_gpio_direction_out(struct gpio_chip *chip,
>
> static void arizona_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
> {
> - struct arizona_gpio *arizona_gpio = to_arizona_gpio(chip);
> + struct arizona_gpio *arizona_gpio = gpiochip_get_data(chip);
> struct arizona *arizona = arizona_gpio->arizona;
>
> if (value)
> @@ -133,7 +128,7 @@ static int arizona_gpio_probe(struct platform_device *pdev)
> else
> arizona_gpio->gpio_chip.base = -1;
>
> - ret = gpiochip_add(&arizona_gpio->gpio_chip);
> + ret = gpiochip_add_data(&arizona_gpio->gpio_chip, arizona_gpio);
> if (ret < 0) {
> dev_err(&pdev->dev, "Could not register gpiochip, %d\n",
> ret);
Looks ok.
Reviewed-by: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
prev parent reply other threads:[~2015-12-09 13:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 13:14 [PATCH 014/182] gpio: arizona: use gpiochip data pointer Linus Walleij
2015-12-09 13:42 ` Richard Fitzgerald [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449668559.17838.1.camel@rf-debian.wolfsonmicro.main \
--to=rf@opensource.wolfsonmicro.com \
--cc=acourbot@nvidia.com \
--cc=broonie@kernel.org \
--cc=johan@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mpa@pengutronix.de \
--cc=mwelling@ieee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).