Re: [PATCH v4 2/3] hwmon: ltc4283: Add support for the LTC4283 Swap Controller

[Guenter Roeck <linux@roeck-us.net>]

On 12/4/25 08:15, Nuno Sá via B4 Relay wrote:
> From: Nuno Sá <nuno.sa@analog.com>
> 
> Support the LTC4283 How Swap Controller. The device features programmable
> current limit with foldback and independently adjustable inrush current to
> optimize the MOSFET safe operating area (SOA). The SOA timer limits MOSFET
> temperature rise for reliable protection against overstresses.
> 
> An I2C interface and onboard ADC allow monitoring of board current,
> voltage, power, energy, and fault status.
> 
> Signed-off-by: Nuno Sá <nuno.sa@analog.com>

I finally found the time to write module test code for the driver.

Some early feedback:

- The driver must work with non-devicetree systems and without device
   property support. Select defaults where necessary.
- Attributes marked as readable in the is_visible function must be readable.
   It is not acceptable to return -EOPNOTSUPP. That applies to all
   reset_history attributes and maybe to others.
- regmap is configured for 8 bit accesses, but some registers are 16 bit wide.
   The energy register is 48 bit wide, I am not sure if it is safe to use
   regmap_bulk_read() to bypass that. At the very least it seems risky.
   Is there some regmap documentation that guarantees that a bulk operation
   is always executed as a real bulk operation, not as sequence of 8-bit
   operations ? How does this even work to start with on a system with SMBus
   controller ?

Thanks,
Guenter