From: Yingjoe Chen <yingjoe.chen@mediatek.com>
To: Daniel Kurtz <djkurtz@chromium.org>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
Maoguang Meng <maoguang.meng@mediatek.com>,
Axel Lin <axel.lin@ingics.com>,
Hongzhou Yang <hongzhou.yang@mediatek.com>,
Linus Walleij <linus.walleij@linaro.org>,
Patrice Chotard <patrice.chotard@st.com>,
open list <linux-kernel@vger.kernel.org>,
Fabian Frederick <fabf@skynet.be>,
"open list:PIN CONTROL SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] pinctrl: mediatek: convert to arch_initcall
Date: Fri, 18 Dec 2015 23:06:36 +0800 [thread overview]
Message-ID: <1450451196.19539.9.camel@mtksdaap41> (raw)
In-Reply-To: <1450412497-25872-1-git-send-email-djkurtz@chromium.org>
On Fri, 2015-12-18 at 12:21 +0800, Daniel Kurtz wrote:
> Move pinctrl initialization earlier in boot so that real devices can find
> their pctldev without probe deferring.
>
> Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
> ---
> drivers/pinctrl/mediatek/pinctrl-mt6397.c | 2 +-
> drivers/pinctrl/mediatek/pinctrl-mt8127.c | 2 +-
> drivers/pinctrl/mediatek/pinctrl-mt8135.c | 2 +-
> drivers/pinctrl/mediatek/pinctrl-mt8173.c | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/mediatek/pinctrl-mt6397.c b/drivers/pinctrl/mediatek/pinctrl-mt6397.c
> index f9751ae..a3780d4 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-mt6397.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-mt6397.c
> @@ -70,7 +70,7 @@ static int __init mtk_pinctrl_init(void)
> return platform_driver_register(&mtk_pinctrl_driver);
> }
>
> -module_init(mtk_pinctrl_init);
> +arch_initcall(mtk_pinctrl_init);
MT6397 is PMIC, which depends on pwrap on main AP to work. Since
pmic-wrap itself is module_platform_driver, I think it make sense to
keep this one as module_init. Maybe adding a comment to explain why it
is different from others will help.
Joe.C
>
> MODULE_LICENSE("GPL v2");
> MODULE_DESCRIPTION("MediaTek MT6397 Pinctrl Driver");
> diff --git a/drivers/pinctrl/mediatek/pinctrl-mt8127.c b/drivers/pinctrl/mediatek/pinctrl-mt8127.c
> index b317b0b..98e0beb 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-mt8127.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-mt8127.c
> @@ -351,7 +351,7 @@ static int __init mtk_pinctrl_init(void)
> return platform_driver_register(&mtk_pinctrl_driver);
> }
>
> -module_init(mtk_pinctrl_init);
> +arch_initcall(mtk_pinctrl_init);
>
> MODULE_LICENSE("GPL v2");
> MODULE_DESCRIPTION("MediaTek MT8127 Pinctrl Driver");
> diff --git a/drivers/pinctrl/mediatek/pinctrl-mt8135.c b/drivers/pinctrl/mediatek/pinctrl-mt8135.c
> index 404f117..1c153b8 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-mt8135.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-mt8135.c
> @@ -366,7 +366,7 @@ static int __init mtk_pinctrl_init(void)
> return platform_driver_register(&mtk_pinctrl_driver);
> }
>
> -module_init(mtk_pinctrl_init);
> +arch_initcall(mtk_pinctrl_init);
>
> MODULE_LICENSE("GPL");
> MODULE_DESCRIPTION("MediaTek Pinctrl Driver");
> diff --git a/drivers/pinctrl/mediatek/pinctrl-mt8173.c b/drivers/pinctrl/mediatek/pinctrl-mt8173.c
> index ad27184..a62514e 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-mt8173.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-mt8173.c
> @@ -394,7 +394,7 @@ static int __init mtk_pinctrl_init(void)
> return platform_driver_register(&mtk_pinctrl_driver);
> }
>
> -module_init(mtk_pinctrl_init);
> +arch_initcall(mtk_pinctrl_init);
>
> MODULE_LICENSE("GPL v2");
> MODULE_DESCRIPTION("MediaTek Pinctrl Driver");
next prev parent reply other threads:[~2015-12-18 15:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-18 4:21 [PATCH] pinctrl: mediatek: convert to arch_initcall Daniel Kurtz
2015-12-18 15:06 ` Yingjoe Chen [this message]
2015-12-21 6:51 ` Daniel Kurtz
2015-12-21 12:39 ` Yingjoe Chen
2015-12-21 12:45 ` Daniel Kurtz
2015-12-22 10:23 ` Linus Walleij
[not found] ` <CACRpkdbuL5Kjeqb-zJg9DmoxKzy7vphYgBTG-Ffh2i=UVH97ug-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-12-22 13:36 ` Yingjoe Chen
2015-12-22 13:41 ` Daniel Kurtz
-- strict thread matches above, loose matches on Subject: below --
2015-12-22 13:46 Daniel Kurtz
2015-12-22 15:11 ` Linus Walleij
2015-12-30 17:22 ` Mark Brown
2015-12-31 13:45 ` Daniel Kurtz
2015-12-31 22:07 ` Mark Brown
[not found] ` <20151231220712.GD16023-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-01-01 1:56 ` Daniel Kurtz
2016-01-01 14:27 ` Matthias Brugger
2016-01-01 17:29 ` Linus Walleij
2016-01-04 17:12 ` Mark Brown
2016-01-04 18:23 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1450451196.19539.9.camel@mtksdaap41 \
--to=yingjoe.chen@mediatek.com \
--cc=axel.lin@ingics.com \
--cc=djkurtz@chromium.org \
--cc=fabf@skynet.be \
--cc=fabio.estevam@freescale.com \
--cc=hongzhou.yang@mediatek.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=maoguang.meng@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=patrice.chotard@st.com \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).