* [PATCH 02/54] gpio: davinci: Be sure to clamp return value
@ 2015-12-22 14:10 Linus Walleij
2015-12-22 16:07 ` Grygorii Strashko
0 siblings, 1 reply; 2+ messages in thread
From: Linus Walleij @ 2015-12-22 14:10 UTC (permalink / raw)
To: linux-gpio, Grygorii Strashko, Sekhar Nori, Santosh Shilimkar
Cc: Linus Walleij
As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.
Cc: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: Sekhar Nori <nsekhar@ti.com>
Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
drivers/gpio/gpio-davinci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
index 65ebaef935e1..1e3a617e0c10 100644
--- a/drivers/gpio/gpio-davinci.c
+++ b/drivers/gpio/gpio-davinci.c
@@ -125,7 +125,7 @@ static int davinci_gpio_get(struct gpio_chip *chip, unsigned offset)
struct davinci_gpio_controller *d = chip2controller(chip);
struct davinci_gpio_regs __iomem *g = d->regs;
- return (1 << offset) & readl_relaxed(&g->in_data);
+ return !!((1 << offset) & readl_relaxed(&g->in_data));
}
/*
--
2.4.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 02/54] gpio: davinci: Be sure to clamp return value
2015-12-22 14:10 [PATCH 02/54] gpio: davinci: Be sure to clamp return value Linus Walleij
@ 2015-12-22 16:07 ` Grygorii Strashko
0 siblings, 0 replies; 2+ messages in thread
From: Grygorii Strashko @ 2015-12-22 16:07 UTC (permalink / raw)
To: Linus Walleij, linux-gpio, Sekhar Nori, Santosh Shilimkar
On 12/22/2015 04:10 PM, Linus Walleij wrote:
> As we want gpio_chip .get() calls to be able to return negative
> error codes and propagate to drivers, we need to go over all
> drivers and make sure their return values are clamped to [0,1].
> We do this by using the ret = !!(val) design pattern.
>
> Cc: Grygorii Strashko <grygorii.strashko@ti.com>
> Cc: Sekhar Nori <nsekhar@ti.com>
> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/gpio/gpio-davinci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
> index 65ebaef935e1..1e3a617e0c10 100644
> --- a/drivers/gpio/gpio-davinci.c
> +++ b/drivers/gpio/gpio-davinci.c
> @@ -125,7 +125,7 @@ static int davinci_gpio_get(struct gpio_chip *chip, unsigned offset)
> struct davinci_gpio_controller *d = chip2controller(chip);
> struct davinci_gpio_regs __iomem *g = d->regs;
>
> - return (1 << offset) & readl_relaxed(&g->in_data);
> + return !!((1 << offset) & readl_relaxed(&g->in_data));
> }
>
> /*
>
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
--
regards,
-grygorii
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-12-22 16:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-22 14:10 [PATCH 02/54] gpio: davinci: Be sure to clamp return value Linus Walleij
2015-12-22 16:07 ` Grygorii Strashko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).