* [PATCH 05/54] gpio: intel-mid: Be sure to clamp return value
@ 2015-12-22 14:12 Linus Walleij
2015-12-22 22:58 ` David Cohen
0 siblings, 1 reply; 2+ messages in thread
From: Linus Walleij @ 2015-12-22 14:12 UTC (permalink / raw)
To: linux-gpio, David Cohen; +Cc: Linus Walleij
As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.
Cc: David Cohen <david.a.cohen@linux.intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
drivers/gpio/gpio-intel-mid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-intel-mid.c b/drivers/gpio/gpio-intel-mid.c
index 1c46a7ef2680..26d2083a5901 100644
--- a/drivers/gpio/gpio-intel-mid.c
+++ b/drivers/gpio/gpio-intel-mid.c
@@ -120,7 +120,7 @@ static int intel_gpio_get(struct gpio_chip *chip, unsigned offset)
{
void __iomem *gplr = gpio_reg(chip, offset, GPLR);
- return readl(gplr) & BIT(offset % 32);
+ return !!(readl(gplr) & BIT(offset % 32));
}
static void intel_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
--
2.4.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 05/54] gpio: intel-mid: Be sure to clamp return value
2015-12-22 14:12 [PATCH 05/54] gpio: intel-mid: Be sure to clamp return value Linus Walleij
@ 2015-12-22 22:58 ` David Cohen
0 siblings, 0 replies; 2+ messages in thread
From: David Cohen @ 2015-12-22 22:58 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-gpio
On Tue, Dec 22, 2015 at 03:12:05PM +0100, Linus Walleij wrote:
> As we want gpio_chip .get() calls to be able to return negative
> error codes and propagate to drivers, we need to go over all
> drivers and make sure their return values are clamped to [0,1].
> We do this by using the ret = !!(val) design pattern.
>
> Cc: David Cohen <david.a.cohen@linux.intel.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Sounds good to me :)
Acked-by: David Cohen <david.a.cohen@linux.intel.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-12-22 22:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-22 14:12 [PATCH 05/54] gpio: intel-mid: Be sure to clamp return value Linus Walleij
2015-12-22 22:58 ` David Cohen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).