* [PATCH 24/54] pinctrl: baytrail: Be sure to clamp return value
@ 2015-12-22 14:28 Linus Walleij
2015-12-23 8:53 ` Mika Westerberg
2015-12-23 9:12 ` Heikki Krogerus
0 siblings, 2 replies; 3+ messages in thread
From: Linus Walleij @ 2015-12-22 14:28 UTC (permalink / raw)
To: linux-gpio, Mika Westerberg, Heikki Krogerus; +Cc: Linus Walleij
As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
drivers/pinctrl/intel/pinctrl-baytrail.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/intel/pinctrl-baytrail.c b/drivers/pinctrl/intel/pinctrl-baytrail.c
index bb92f8ae6b33..1fe9c1989353 100644
--- a/drivers/pinctrl/intel/pinctrl-baytrail.c
+++ b/drivers/pinctrl/intel/pinctrl-baytrail.c
@@ -281,7 +281,7 @@ static int byt_gpio_get(struct gpio_chip *chip, unsigned offset)
val = readl(reg);
raw_spin_unlock_irqrestore(&vg->lock, flags);
- return val & BYT_LEVEL;
+ return !!(val & BYT_LEVEL);
}
static void byt_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
--
2.4.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 24/54] pinctrl: baytrail: Be sure to clamp return value
2015-12-22 14:28 [PATCH 24/54] pinctrl: baytrail: Be sure to clamp return value Linus Walleij
@ 2015-12-23 8:53 ` Mika Westerberg
2015-12-23 9:12 ` Heikki Krogerus
1 sibling, 0 replies; 3+ messages in thread
From: Mika Westerberg @ 2015-12-23 8:53 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-gpio, Heikki Krogerus
On Tue, Dec 22, 2015 at 03:28:48PM +0100, Linus Walleij wrote:
> As we want gpio_chip .get() calls to be able to return negative
> error codes and propagate to drivers, we need to go over all
> drivers and make sure their return values are clamped to [0,1].
> We do this by using the ret = !!(val) design pattern.
>
> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 24/54] pinctrl: baytrail: Be sure to clamp return value
2015-12-22 14:28 [PATCH 24/54] pinctrl: baytrail: Be sure to clamp return value Linus Walleij
2015-12-23 8:53 ` Mika Westerberg
@ 2015-12-23 9:12 ` Heikki Krogerus
1 sibling, 0 replies; 3+ messages in thread
From: Heikki Krogerus @ 2015-12-23 9:12 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-gpio, Mika Westerberg
On Tue, Dec 22, 2015 at 03:28:48PM +0100, Linus Walleij wrote:
> As we want gpio_chip .get() calls to be able to return negative
> error codes and propagate to drivers, we need to go over all
> drivers and make sure their return values are clamped to [0,1].
> We do this by using the ret = !!(val) design pattern.
>
> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
--
heikki
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-12-23 9:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-22 14:28 [PATCH 24/54] pinctrl: baytrail: Be sure to clamp return value Linus Walleij
2015-12-23 8:53 ` Mika Westerberg
2015-12-23 9:12 ` Heikki Krogerus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).