From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: [PATCH 45/54] mfd: asic3: Be sure to clamp return value Date: Tue, 22 Dec 2015 15:45:26 +0100 Message-ID: <1450795526-27949-1-git-send-email-linus.walleij@linaro.org> Return-path: Received: from mail-lf0-f44.google.com ([209.85.215.44]:33011 "EHLO mail-lf0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752917AbbLVOpd (ORCPT ); Tue, 22 Dec 2015 09:45:33 -0500 Received: by mail-lf0-f44.google.com with SMTP id p203so132009590lfa.0 for ; Tue, 22 Dec 2015 06:45:32 -0800 (PST) Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: linux-gpio@vger.kernel.org, Guan Xuetao Cc: Linus Walleij , Paul Parsons , Lee Jones As we want gpio_chip .get() calls to be able to return negative error codes and propagate to drivers, we need to go over all drivers and make sure their return values are clamped to [0,1]. We do this by using the ret = !!(val) design pattern. Cc: Paul Parsons Cc: Lee Jones Signed-off-by: Linus Walleij --- Lee: as mentioned in 00/54: either apply this directly or ACK it and I will take it into the GPIO tree. --- drivers/mfd/asic3.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/asic3.c b/drivers/mfd/asic3.c index a726f01e3b02..58c4d9cb8e8d 100644 --- a/drivers/mfd/asic3.c +++ b/drivers/mfd/asic3.c @@ -502,7 +502,8 @@ static int asic3_gpio_get(struct gpio_chip *chip, return -EINVAL; } - return asic3_read_register(asic, gpio_base + ASIC3_GPIO_STATUS) & mask; + return !!(asic3_read_register(asic, gpio_base + ASIC3_GPIO_STATUS) + & mask)); } static void asic3_gpio_set(struct gpio_chip *chip, -- 2.4.3