* [PATCH 0/2] pinctrl: sh-pfc: r8a7795: Errata for Rev 0.50 datasheet
@ 2016-01-15 11:07 Geert Uytterhoeven
2016-01-15 11:07 ` [PATCH 1/2] pinctrl: sh-pfc: r8a7795: Rename SSI_{WS,SCK}0129 to SSI_{WS,SCK}01239 Geert Uytterhoeven
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Geert Uytterhoeven @ 2016-01-15 11:07 UTC (permalink / raw)
To: Laurent Pinchart, Linus Walleij; +Cc: linux-sh, linux-gpio, Geert Uytterhoeven
Hi Linus, Laurent,
This patch series synchronize the R-Car M3 (r8a7795) pin control driver
code with the latest Manual Errata for Rev 0.50 of the R-Car Gen3
datasheet. None of this has user-visible impact.
Laurent: As the first patch depends on (big) "[PATCH v3 2/2]
pinctrl: sh-pfc: Rename PINMUX_IPSR_DATA() to PINMUX_IPSR_GPSR()", from
series "[PATCH v3 0/2] pinctrl: sh-pfc: Improve pinmux macros
documentation", and you had comments on earlier versions of that series,
it would be good to receive an ack for that series first
(https://www.spinics.net/lists/linux-gpio/msg09949.html).
Thanks!
Geert Uytterhoeven (2):
pinctrl: sh-pfc: r8a7795: Rename SSI_{WS,SCK}0129 to SSI_{WS,SCK}01239
pinctrl: sh-pfc: r8a7795: Remove bits SEL_VSP_1 and SEL_VSP_0
drivers/pinctrl/sh-pfc/pfc-r8a7795.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
--
1.9.1
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH 1/2] pinctrl: sh-pfc: r8a7795: Rename SSI_{WS,SCK}0129 to SSI_{WS,SCK}01239 2016-01-15 11:07 [PATCH 0/2] pinctrl: sh-pfc: r8a7795: Errata for Rev 0.50 datasheet Geert Uytterhoeven @ 2016-01-15 11:07 ` Geert Uytterhoeven 2016-01-20 13:04 ` Linus Walleij 2016-01-15 11:07 ` [PATCH 2/2] pinctrl: sh-pfc: r8a7795: Remove bits SEL_VSP_1 and SEL_VSP_0 Geert Uytterhoeven 2016-01-15 23:15 ` [PATCH 0/2] pinctrl: sh-pfc: r8a7795: Errata for Rev 0.50 datasheet Laurent Pinchart 2 siblings, 1 reply; 8+ messages in thread From: Geert Uytterhoeven @ 2016-01-15 11:07 UTC (permalink / raw) To: Laurent Pinchart, Linus Walleij; +Cc: linux-sh, linux-gpio, Geert Uytterhoeven Cfr. Manual Errata for Rev 0.50 of the R-Car Gen3 datasheet. This has no user-visible impact, as the string used for configuration ("ssi01239_ctrl") was already correct. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/pinctrl/sh-pfc/pfc-r8a7795.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7795.c b/drivers/pinctrl/sh-pfc/pfc-r8a7795.c index bcd56affb81350d1..ca55ec92c7716e88 100644 --- a/drivers/pinctrl/sh-pfc/pfc-r8a7795.c +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7795.c @@ -189,8 +189,8 @@ #define GPSR6_4 F_(SSI_SDATA2_A, IP14_7_4) #define GPSR6_3 F_(SSI_SDATA1_A, IP14_3_0) #define GPSR6_2 F_(SSI_SDATA0, IP13_31_28) -#define GPSR6_1 F_(SSI_WS0129, IP13_27_24) -#define GPSR6_0 F_(SSI_SCK0129, IP13_23_20) +#define GPSR6_1 F_(SSI_WS01239, IP13_27_24) +#define GPSR6_0 F_(SSI_SCK01239, IP13_23_20) /* GPSR7 */ #define GPSR7_3 FM(HDMI1_CEC) @@ -315,8 +315,8 @@ #define IP13_11_8 FM(MLB_CLK) F_(0, 0) FM(MSIOF1_SCK_F) F_(0, 0) FM(SCL1_B) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) #define IP13_15_12 FM(MLB_SIG) FM(RX1_B) FM(MSIOF1_SYNC_F) F_(0, 0) FM(SDA1_B) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) #define IP13_19_16 FM(MLB_DAT) FM(TX1_B) FM(MSIOF1_RXD_F) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) -#define IP13_23_20 FM(SSI_SCK0129) F_(0, 0) FM(MSIOF1_TXD_F) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) -#define IP13_27_24 FM(SSI_WS0129) F_(0, 0) FM(MSIOF1_SS1_F) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) +#define IP13_23_20 FM(SSI_SCK01239) F_(0, 0) FM(MSIOF1_TXD_F) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) +#define IP13_27_24 FM(SSI_WS01239) F_(0, 0) FM(MSIOF1_SS1_F) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) #define IP13_31_28 FM(SSI_SDATA0) F_(0, 0) FM(MSIOF1_SS2_F) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) #define IP14_3_0 FM(SSI_SDATA1_A) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) #define IP14_7_4 FM(SSI_SDATA2_A) F_(0, 0) F_(0, 0) F_(0, 0) FM(SSI_SCK1_B) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) F_(0, 0) @@ -1214,10 +1214,10 @@ static const u16 pinmux_data[] = { PINMUX_IPSR_MSEL(IP13_19_16, TX1_B, SEL_SCIF1_1), PINMUX_IPSR_MSEL(IP13_19_16, MSIOF1_RXD_F, SEL_MSIOF1_5), - PINMUX_IPSR_GPSR(IP13_23_20, SSI_SCK0129), + PINMUX_IPSR_GPSR(IP13_23_20, SSI_SCK01239), PINMUX_IPSR_MSEL(IP13_23_20, MSIOF1_TXD_F, SEL_MSIOF1_5), - PINMUX_IPSR_GPSR(IP13_27_24, SSI_WS0129), + PINMUX_IPSR_GPSR(IP13_27_24, SSI_WS01239), PINMUX_IPSR_MSEL(IP13_27_24, MSIOF1_SS1_F, SEL_MSIOF1_5), PINMUX_IPSR_GPSR(IP13_31_28, SSI_SDATA0), @@ -2926,7 +2926,7 @@ static const unsigned int ssi01239_ctrl_pins[] = { RCAR_GP_PIN(6, 0), RCAR_GP_PIN(6, 1), }; static const unsigned int ssi01239_ctrl_mux[] = { - SSI_SCK0129_MARK, SSI_WS0129_MARK, + SSI_SCK01239_MARK, SSI_WS01239_MARK, }; static const unsigned int ssi1_data_a_pins[] = { /* SDATA */ -- 1.9.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] pinctrl: sh-pfc: r8a7795: Rename SSI_{WS,SCK}0129 to SSI_{WS,SCK}01239 2016-01-15 11:07 ` [PATCH 1/2] pinctrl: sh-pfc: r8a7795: Rename SSI_{WS,SCK}0129 to SSI_{WS,SCK}01239 Geert Uytterhoeven @ 2016-01-20 13:04 ` Linus Walleij 2016-01-20 13:17 ` Geert Uytterhoeven 0 siblings, 1 reply; 8+ messages in thread From: Linus Walleij @ 2016-01-20 13:04 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Laurent Pinchart, linux-sh@vger.kernel.org, linux-gpio@vger.kernel.org On Fri, Jan 15, 2016 at 12:07 PM, Geert Uytterhoeven <geert+renesas@glider.be> wrote: > Cfr. Manual Errata for Rev 0.50 of the R-Car Gen3 datasheet. > > This has no user-visible impact, as the string used for configuration > ("ssi01239_ctrl") was already correct. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Are these regressions that need to go in as fixes? Yours, Linus Walleij ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] pinctrl: sh-pfc: r8a7795: Rename SSI_{WS,SCK}0129 to SSI_{WS,SCK}01239 2016-01-20 13:04 ` Linus Walleij @ 2016-01-20 13:17 ` Geert Uytterhoeven 2016-01-27 14:09 ` Linus Walleij 0 siblings, 1 reply; 8+ messages in thread From: Geert Uytterhoeven @ 2016-01-20 13:17 UTC (permalink / raw) To: Linus Walleij Cc: Geert Uytterhoeven, Laurent Pinchart, linux-sh@vger.kernel.org, linux-gpio@vger.kernel.org Hi Linus, On Wed, Jan 20, 2016 at 2:04 PM, Linus Walleij <linus.walleij@linaro.org> wrote: > On Fri, Jan 15, 2016 at 12:07 PM, Geert Uytterhoeven > <geert+renesas@glider.be> wrote: > >> Cfr. Manual Errata for Rev 0.50 of the R-Car Gen3 datasheet. >> >> This has no user-visible impact, as the string used for configuration >> ("ssi01239_ctrl") was already correct. >> >> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Are these regressions that need to go in as fixes? No, I plan to queue them on a branch for v4.6. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] pinctrl: sh-pfc: r8a7795: Rename SSI_{WS,SCK}0129 to SSI_{WS,SCK}01239 2016-01-20 13:17 ` Geert Uytterhoeven @ 2016-01-27 14:09 ` Linus Walleij 0 siblings, 0 replies; 8+ messages in thread From: Linus Walleij @ 2016-01-27 14:09 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Geert Uytterhoeven, Laurent Pinchart, linux-sh@vger.kernel.org, linux-gpio@vger.kernel.org On Wed, Jan 20, 2016 at 2:17 PM, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > Hi Linus, > > On Wed, Jan 20, 2016 at 2:04 PM, Linus Walleij <linus.walleij@linaro.org> wrote: >> On Fri, Jan 15, 2016 at 12:07 PM, Geert Uytterhoeven >> <geert+renesas@glider.be> wrote: >> >>> Cfr. Manual Errata for Rev 0.50 of the R-Car Gen3 datasheet. >>> >>> This has no user-visible impact, as the string used for configuration >>> ("ssi01239_ctrl") was already correct. >>> >>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> >> >> Are these regressions that need to go in as fixes? > > No, I plan to queue them on a branch for v4.6. Excellent, Acked-by. Yours, Linus Walleij ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/2] pinctrl: sh-pfc: r8a7795: Remove bits SEL_VSP_1 and SEL_VSP_0 2016-01-15 11:07 [PATCH 0/2] pinctrl: sh-pfc: r8a7795: Errata for Rev 0.50 datasheet Geert Uytterhoeven 2016-01-15 11:07 ` [PATCH 1/2] pinctrl: sh-pfc: r8a7795: Rename SSI_{WS,SCK}0129 to SSI_{WS,SCK}01239 Geert Uytterhoeven @ 2016-01-15 11:07 ` Geert Uytterhoeven 2016-01-27 9:53 ` Linus Walleij 2016-01-15 23:15 ` [PATCH 0/2] pinctrl: sh-pfc: r8a7795: Errata for Rev 0.50 datasheet Laurent Pinchart 2 siblings, 1 reply; 8+ messages in thread From: Geert Uytterhoeven @ 2016-01-15 11:07 UTC (permalink / raw) To: Laurent Pinchart, Linus Walleij; +Cc: linux-sh, linux-gpio, Geert Uytterhoeven Cfr. Manual Errata for Rev 0.50 of the R-Car Gen3 datasheet. This has no user-visible impact, as the definitions were not really used. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/pinctrl/sh-pfc/pfc-r8a7795.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7795.c b/drivers/pinctrl/sh-pfc/pfc-r8a7795.c index ca55ec92c7716e88..5091cffbc6128d26 100644 --- a/drivers/pinctrl/sh-pfc/pfc-r8a7795.c +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7795.c @@ -478,7 +478,6 @@ FM(IP16_31_28) IP16_31_28 #define MOD_SEL2_31 FM(I2C_SEL_5_0) FM(I2C_SEL_5_1) #define MOD_SEL2_30 FM(I2C_SEL_3_0) FM(I2C_SEL_3_1) #define MOD_SEL2_29 FM(I2C_SEL_0_0) FM(I2C_SEL_0_1) -#define MOD_SEL2_2_1 FM(SEL_VSP_0) FM(SEL_VSP_1) FM(SEL_VSP_2) FM(SEL_VSP_3) #define MOD_SEL2_0 FM(SEL_VIN4_0) FM(SEL_VIN4_1) #define PINMUX_MOD_SELS\ @@ -512,7 +511,7 @@ MOD_SEL0_7_6 \ MOD_SEL0_5_4 MOD_SEL1_5 \ MOD_SEL1_4 \ MOD_SEL0_3 MOD_SEL1_3 \ -MOD_SEL0_2_1 MOD_SEL1_2 MOD_SEL2_2_1 \ +MOD_SEL0_2_1 MOD_SEL1_2 \ MOD_SEL1_1 \ MOD_SEL1_0 MOD_SEL2_0 @@ -4213,7 +4212,8 @@ static const struct pinmux_cfg_reg pinmux_config_regs[] = { 0, 0, 0, 0, 0, 0, 0, 0, /* RESERVED 3 */ 0, 0, - MOD_SEL2_2_1 + /* RESERVED 2, 1 */ + 0, 0, 0, 0, MOD_SEL2_0 } }, { }, -- 1.9.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] pinctrl: sh-pfc: r8a7795: Remove bits SEL_VSP_1 and SEL_VSP_0 2016-01-15 11:07 ` [PATCH 2/2] pinctrl: sh-pfc: r8a7795: Remove bits SEL_VSP_1 and SEL_VSP_0 Geert Uytterhoeven @ 2016-01-27 9:53 ` Linus Walleij 0 siblings, 0 replies; 8+ messages in thread From: Linus Walleij @ 2016-01-27 9:53 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Laurent Pinchart, linux-sh@vger.kernel.org, linux-gpio@vger.kernel.org On Fri, Jan 15, 2016 at 12:07 PM, Geert Uytterhoeven <geert+renesas@glider.be> wrote: > Cfr. Manual Errata for Rev 0.50 of the R-Car Gen3 datasheet. > > This has no user-visible impact, as the definitions were not really > used. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Acked-by: Linus Walleij <linus.walleij@linaro.org> I guess there will still be a huge influx of SH-PFC patches so we should keep running pull request from you to me for the v4.6 kernel cycle. Yours, Linus Walleij ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/2] pinctrl: sh-pfc: r8a7795: Errata for Rev 0.50 datasheet 2016-01-15 11:07 [PATCH 0/2] pinctrl: sh-pfc: r8a7795: Errata for Rev 0.50 datasheet Geert Uytterhoeven 2016-01-15 11:07 ` [PATCH 1/2] pinctrl: sh-pfc: r8a7795: Rename SSI_{WS,SCK}0129 to SSI_{WS,SCK}01239 Geert Uytterhoeven 2016-01-15 11:07 ` [PATCH 2/2] pinctrl: sh-pfc: r8a7795: Remove bits SEL_VSP_1 and SEL_VSP_0 Geert Uytterhoeven @ 2016-01-15 23:15 ` Laurent Pinchart 2 siblings, 0 replies; 8+ messages in thread From: Laurent Pinchart @ 2016-01-15 23:15 UTC (permalink / raw) To: Geert Uytterhoeven; +Cc: Linus Walleij, linux-sh, linux-gpio Hi Geert, On Friday 15 January 2016 12:07:02 Geert Uytterhoeven wrote: > Hi Linus, Laurent, > > This patch series synchronize the R-Car M3 (r8a7795) pin control driver > code with the latest Manual Errata for Rev 0.50 of the R-Car Gen3 > datasheet. None of this has user-visible impact. > > Laurent: As the first patch depends on (big) "[PATCH v3 2/2] > pinctrl: sh-pfc: Rename PINMUX_IPSR_DATA() to PINMUX_IPSR_GPSR()", from > series "[PATCH v3 0/2] pinctrl: sh-pfc: Improve pinmux macros > documentation", and you had comments on earlier versions of that series, > it would be good to receive an ack for that series first > (https://www.spinics.net/lists/linux-gpio/msg09949.html). I'll handle it with the highest vacation-compatible priority :-) I'll have my computer with me this week :-/ > Geert Uytterhoeven (2): > pinctrl: sh-pfc: r8a7795: Rename SSI_{WS,SCK}0129 to SSI_{WS,SCK}01239 > pinctrl: sh-pfc: r8a7795: Remove bits SEL_VSP_1 and SEL_VSP_0 > > drivers/pinctrl/sh-pfc/pfc-r8a7795.c | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-01-27 14:09 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-15 11:07 [PATCH 0/2] pinctrl: sh-pfc: r8a7795: Errata for Rev 0.50 datasheet Geert Uytterhoeven
2016-01-15 11:07 ` [PATCH 1/2] pinctrl: sh-pfc: r8a7795: Rename SSI_{WS,SCK}0129 to SSI_{WS,SCK}01239 Geert Uytterhoeven
2016-01-20 13:04 ` Linus Walleij
2016-01-20 13:17 ` Geert Uytterhoeven
2016-01-27 14:09 ` Linus Walleij
2016-01-15 11:07 ` [PATCH 2/2] pinctrl: sh-pfc: r8a7795: Remove bits SEL_VSP_1 and SEL_VSP_0 Geert Uytterhoeven
2016-01-27 9:53 ` Linus Walleij
2016-01-15 23:15 ` [PATCH 0/2] pinctrl: sh-pfc: r8a7795: Errata for Rev 0.50 datasheet Laurent Pinchart
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).