From: Yingjoe Chen <yingjoe.chen@mediatek.com>
To: John Crispin <blogic@openwrt.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 2/2] pinctrl: mediatek: Add pinctrl files for MT7623
Date: Wed, 20 Jan 2016 17:41:23 +0800 [thread overview]
Message-ID: <1453282883.16515.14.camel@mtksdaap41> (raw)
In-Reply-To: <1452441608-24176-2-git-send-email-blogic@openwrt.org>
On Sun, 2016-01-10 at 17:00 +0100, John Crispin wrote:
> Add the driver and header files required to make pinctrl work on MediaTek
> MT7623.
>
> Signed-off-by: John Crispin <blogic@openwrt.org>
> ---
> drivers/pinctrl/mediatek/Kconfig | 5 +
> drivers/pinctrl/mediatek/Makefile | 1 +
> drivers/pinctrl/mediatek/pinctrl-mt7623.c | 380 +++++
> drivers/pinctrl/mediatek/pinctrl-mtk-mt7623.h | 1936 +++++++++++++++++++++++++
> include/dt-bindings/pinctrl/mt7623-pinfunc.h | 520 +++++++
> 5 files changed, 2842 insertions(+)
> create mode 100644 drivers/pinctrl/mediatek/pinctrl-mt7623.c
> create mode 100644 drivers/pinctrl/mediatek/pinctrl-mtk-mt7623.h
> create mode 100644 include/dt-bindings/pinctrl/mt7623-pinfunc.h
>
> diff --git a/drivers/pinctrl/mediatek/Kconfig b/drivers/pinctrl/mediatek/Kconfig
> index 13e9939..8cc6b8a 100644
> --- a/drivers/pinctrl/mediatek/Kconfig
> +++ b/drivers/pinctrl/mediatek/Kconfig
> @@ -13,6 +13,11 @@ config PINCTRL_MT2701
> bool "Mediatek MT2701 pin control" if COMPILE_TEST && !MACH_MT2701
> depends on OF
> default MACH_MT2701
> +
> +config PINCTRL_MT7623
> + bool "Mediatek MT7623 pin control" if COMPILE_TEST && !MACH_MT7623
> + depends on OF
> + default MACH_MT7623
> select PINCTRL_MTK_COMMON
Hi John,
You removed 'select PINCTRL_MTK_COMMON' form PINCTRL_MT2701. Please add
it back.
<...>
> diff --git a/include/dt-bindings/pinctrl/mt7623-pinfunc.h b/include/dt-bindings/pinctrl/mt7623-pinfunc.h
> new file mode 100644
> index 0000000..d8a0f2e
> --- /dev/null
> +++ b/include/dt-bindings/pinctrl/mt7623-pinfunc.h
> @@ -0,0 +1,520 @@
> +#ifndef __DTS_MT7623_PINFUNC_H
> +#define __DTS_MT7623_PINFUNC_H
> +
> +#include <dt-bindings/pinctrl/mt65xx.h>
> +
<...>
This is part of dt-binding. I think it should be a separate patch or go
with the dt-binding patch.
Joe.C
next prev parent reply other threads:[~2016-01-20 9:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-10 16:00 [PATCH 1/2] dt-bindings: mediatek: Modify pinctrl bindings for mt7623 John Crispin
2016-01-10 16:00 ` [PATCH 2/2] pinctrl: mediatek: Add pinctrl files for MT7623 John Crispin
2016-01-10 16:40 ` John Crispin
2016-01-20 9:41 ` Yingjoe Chen [this message]
2016-01-20 9:34 ` [PATCH 1/2] dt-bindings: mediatek: Modify pinctrl bindings for mt7623 Yingjoe Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453282883.16515.14.camel@mtksdaap41 \
--to=yingjoe.chen@mediatek.com \
--cc=blogic@openwrt.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).