From: Krzysztof Adamski <k@japko.eu>
To: Linus Walleij
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Vishnu Patekar
<vishnupatekar0510-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Krzysztof Adamski <k@japko.eu>,
Jens Kuske <jenskuske-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: [PATCH v2 5/5] pinctrl: sunxi: Use pin number when calling sunxi_pmx_set
Date: Tue, 2 Feb 2016 22:21:53 +0100 [thread overview]
Message-ID: <1454448113-18810-6-git-send-email-k@japko.eu> (raw)
In-Reply-To: <1454448113-18810-1-git-send-email-k-P4rZei/IPtg@public.gmane.org>
sunxi_pmx_set accepts pin number and then calculates offset by
subtracting pin_base from it. sunxi_pinctrl_gpio_get, on the other hand,
gets offset so we have to convert it to pin number so we won't get
negative value in sunxi_pmx_set.
This was only used on A10 so far, where there is only one GPIO chip with
pin_base set to 0 so it didn't matter. However H3 also requires this
workaround but have two pinmux sections, triggering problem for PL port.
Signed-off-by: Krzysztof Adamski <k@japko.eu>
---
drivers/pinctrl/sunxi/pinctrl-sunxi.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.c b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
index 7a2465f..9e5bac9 100644
--- a/drivers/pinctrl/sunxi/pinctrl-sunxi.c
+++ b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
@@ -460,14 +460,17 @@ static int sunxi_pinctrl_gpio_get(struct gpio_chip *chip, unsigned offset)
u32 set_mux = pctl->desc->irq_read_needs_mux &&
test_bit(FLAG_USED_AS_IRQ, &chip->desc[offset].flags);
u32 val;
+ u32 pin;
- if (set_mux)
- sunxi_pmx_set(pctl->pctl_dev, offset, SUN4I_FUNC_INPUT);
+ if (set_mux) {
+ pin = offset + pctl->desc->pin_base;
+ sunxi_pmx_set(pctl->pctl_dev, pin, SUN4I_FUNC_INPUT);
+ }
val = (readl(pctl->membase + reg) >> index) & DATA_PINS_MASK;
if (set_mux)
- sunxi_pmx_set(pctl->pctl_dev, offset, SUN4I_FUNC_IRQ);
+ sunxi_pmx_set(pctl->pctl_dev, pin, SUN4I_FUNC_IRQ);
return !!val;
}
--
2.1.4
next prev parent reply other threads:[~2016-02-02 21:21 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 21:21 [PATCH v2 0/5] pinctrl: sunxi: Add H3 R_PIO controller support Krzysztof Adamski
2016-02-02 21:21 ` [PATCH v2 2/5] dts: sun8i-h3: Add APB0 related clocks and resets Krzysztof Adamski
[not found] ` <1454448113-18810-3-git-send-email-k-P4rZei/IPtg@public.gmane.org>
2016-02-03 12:35 ` Maxime Ripard
2016-02-03 22:21 ` Krzysztof Adamski
[not found] ` <20160203222117.GA12071-xLeyfSbClftGit24Ens98Q@public.gmane.org>
2016-02-03 23:44 ` Krzysztof Adamski
[not found] ` <1454448113-18810-1-git-send-email-k-P4rZei/IPtg@public.gmane.org>
2016-02-02 21:21 ` [PATCH v2 1/5] clk: sunxi: Add apb0 gates for H3 Krzysztof Adamski
[not found] ` <1454448113-18810-2-git-send-email-k-P4rZei/IPtg@public.gmane.org>
2016-02-03 7:04 ` Chen-Yu Tsai
2016-02-02 21:21 ` [PATCH v2 3/5] pinctrl: sunxi: Add H3 R_PIO controller support Krzysztof Adamski
[not found] ` <1454448113-18810-4-git-send-email-k-P4rZei/IPtg@public.gmane.org>
2016-02-03 12:36 ` Maxime Ripard
2016-02-11 13:21 ` Linus Walleij
2016-02-15 8:08 ` [linux-sunxi] " Krzysztof Adamski
[not found] ` <20160215080816.GA6426-xLeyfSbClftGit24Ens98Q@public.gmane.org>
2016-02-15 9:17 ` Linus Walleij
[not found] ` <CACRpkdbfNeh7_=3ReQtJc7OxkkQEn+BUhZ0O0SKnFsRD=WZiUQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-18 15:03 ` [PATCH] clk: sunxi: Add missing H3 apb0 clock documentation Krzysztof Adamski
[not found] ` <1455807809-30827-1-git-send-email-k-P4rZei/IPtg@public.gmane.org>
2016-02-18 17:07 ` Chen-Yu Tsai
2016-02-18 19:42 ` [linux-sunxi] " Krzysztof Adamski
2016-02-18 19:49 ` [PATCH] pinctrl: sunxi: Add missing H3 R_PIO binding documentation Krzysztof Adamski
[not found] ` <20160218194931.GA16393-xLeyfSbClftGit24Ens98Q@public.gmane.org>
2016-02-21 18:29 ` Chen-Yu Tsai
2016-02-25 9:27 ` Linus Walleij
2016-02-02 21:21 ` [PATCH v2 4/5] ARM: dts: sun8i-h3: Add R_PIO controller node to the dtsi Krzysztof Adamski
[not found] ` <1454448113-18810-5-git-send-email-k-P4rZei/IPtg@public.gmane.org>
2016-02-02 22:19 ` Julian Calaby
2016-02-02 21:21 ` Krzysztof Adamski [this message]
2016-02-03 7:02 ` [PATCH v2 5/5] pinctrl: sunxi: Use pin number when calling sunxi_pmx_set Chen-Yu Tsai
[not found] ` <1454448113-18810-6-git-send-email-k-P4rZei/IPtg@public.gmane.org>
2016-02-11 13:17 ` Linus Walleij
[not found] ` <CACRpkdbc0SfKiCGwUGA2fAPPsUhGv=qGV607Lht6ByYKKgTHjA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-11 13:20 ` Krzysztof Adamski
[not found] ` <20160211132054.GC19622-xLeyfSbClftGit24Ens98Q@public.gmane.org>
2016-02-11 13:50 ` Linus Walleij
2016-02-11 13:21 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454448113-18810-6-git-send-email-k@japko.eu \
--to=k@japko.eu \
--cc=hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=jenskuske-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
--cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=vishnupatekar0510-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=wens-jdAy2FN1RRM@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).