From: Axel Lin <axel.lin@ingics.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Julien Grossholtz <julien.grossholtz@savoirfairelinux.com>,
Alexandre Courbot <gnurou@gmail.com>,
linux-gpio@vger.kernel.org
Subject: [PATCH RFT] gpio: ts4800: Fixup flags argument for bgpio_init
Date: Fri, 12 Feb 2016 12:16:30 +0800 [thread overview]
Message-ID: <1455250590.9777.1.camel@ingics.com> (raw)
BGPIOF_BIG_ENDIAN & BGPIOF_BIG_ENDIAN_BYTE_ORDER is 0.
Fixup the trivial typo.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
Hi Julien,
I don't have this h/w, can you review and test if this patch works.
Thanks,
Axel
drivers/gpio/gpio-ts4800.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-ts4800.c b/drivers/gpio/gpio-ts4800.c
index c4908a4..c244c31 100644
--- a/drivers/gpio/gpio-ts4800.c
+++ b/drivers/gpio/gpio-ts4800.c
@@ -49,7 +49,7 @@ static int ts4800_gpio_probe(struct platform_device *pdev)
retval = bgpio_init(chip, &pdev->dev, 2, base_addr + INPUT_REG_OFFSET,
base_addr + OUTPUT_REG_OFFSET, NULL,
base_addr + DIRECTION_REG_OFFSET, NULL,
- BGPIOF_BIG_ENDIAN & BGPIOF_BIG_ENDIAN_BYTE_ORDER);
+ BGPIOF_BIG_ENDIAN | BGPIOF_BIG_ENDIAN_BYTE_ORDER);
if (retval) {
dev_err(&pdev->dev, "bgpio_init failed\n");
return retval;
--
2.1.4
next reply other threads:[~2016-02-12 4:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 4:16 Axel Lin [this message]
2016-02-12 14:42 ` [PATCH RFT] gpio: ts4800: Fixup flags argument for bgpio_init Julien Grossholtz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455250590.9777.1.camel@ingics.com \
--to=axel.lin@ingics.com \
--cc=gnurou@gmail.com \
--cc=julien.grossholtz@savoirfairelinux.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).