From: Axel Lin <axel.lin@ingics.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "Andrew F. Davis" <afd@ti.com>,
Alexandre Courbot <gnurou@gmail.com>,
linux-gpio@vger.kernel.org
Subject: [PATCH 1/2] gpio: tpic2810: Make tpic2810_direction_output set proper output level
Date: Mon, 15 Feb 2016 20:09:14 +0800 [thread overview]
Message-ID: <1455538154.9793.2.camel@ingics.com> (raw)
The .direction_output callback should set proper output level.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/gpio/gpio-tpic2810.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpio/gpio-tpic2810.c b/drivers/gpio/gpio-tpic2810.c
index 032d058..9f020aa 100644
--- a/drivers/gpio/gpio-tpic2810.c
+++ b/drivers/gpio/gpio-tpic2810.c
@@ -33,6 +33,8 @@ struct tpic2810 {
struct mutex lock;
};
+static void tpic2810_set(struct gpio_chip *chip, unsigned offset, int value);
+
static int tpic2810_get_direction(struct gpio_chip *chip,
unsigned offset)
{
@@ -51,6 +53,7 @@ static int tpic2810_direction_output(struct gpio_chip *chip,
unsigned offset, int value)
{
/* This device always output */
+ tpic2810_set(chip, offset, value);
return 0;
}
--
2.1.4
next reply other threads:[~2016-02-15 12:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 12:09 Axel Lin [this message]
2016-02-15 12:10 ` [PATCH 2/2] gpio: tps65218: Make tps65218_gpio_output set proper output level Axel Lin
2016-02-16 14:58 ` Linus Walleij
2016-02-16 14:57 ` [PATCH 1/2] gpio: tpic2810: Make tpic2810_direction_output " Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455538154.9793.2.camel@ingics.com \
--to=axel.lin@ingics.com \
--cc=afd@ti.com \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).