* [PATCH 1/2] gpio: tpic2810: Make tpic2810_direction_output set proper output level
@ 2016-02-15 12:09 Axel Lin
2016-02-15 12:10 ` [PATCH 2/2] gpio: tps65218: Make tps65218_gpio_output " Axel Lin
2016-02-16 14:57 ` [PATCH 1/2] gpio: tpic2810: Make tpic2810_direction_output " Linus Walleij
0 siblings, 2 replies; 4+ messages in thread
From: Axel Lin @ 2016-02-15 12:09 UTC (permalink / raw)
To: Linus Walleij; +Cc: Andrew F. Davis, Alexandre Courbot, linux-gpio
The .direction_output callback should set proper output level.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/gpio/gpio-tpic2810.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpio/gpio-tpic2810.c b/drivers/gpio/gpio-tpic2810.c
index 032d058..9f020aa 100644
--- a/drivers/gpio/gpio-tpic2810.c
+++ b/drivers/gpio/gpio-tpic2810.c
@@ -33,6 +33,8 @@ struct tpic2810 {
struct mutex lock;
};
+static void tpic2810_set(struct gpio_chip *chip, unsigned offset, int value);
+
static int tpic2810_get_direction(struct gpio_chip *chip,
unsigned offset)
{
@@ -51,6 +53,7 @@ static int tpic2810_direction_output(struct gpio_chip *chip,
unsigned offset, int value)
{
/* This device always output */
+ tpic2810_set(chip, offset, value);
return 0;
}
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] gpio: tps65218: Make tps65218_gpio_output set proper output level
2016-02-15 12:09 [PATCH 1/2] gpio: tpic2810: Make tpic2810_direction_output set proper output level Axel Lin
@ 2016-02-15 12:10 ` Axel Lin
2016-02-16 14:58 ` Linus Walleij
2016-02-16 14:57 ` [PATCH 1/2] gpio: tpic2810: Make tpic2810_direction_output " Linus Walleij
1 sibling, 1 reply; 4+ messages in thread
From: Axel Lin @ 2016-02-15 12:10 UTC (permalink / raw)
To: Linus Walleij; +Cc: Nicolas Saenz Julienne, Alexandre Courbot, linux-gpio
The .direction_output callback should set proper output level.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/gpio/gpio-tps65218.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/gpio-tps65218.c b/drivers/gpio/gpio-tps65218.c
index 7b02f7b..a308a0b 100644
--- a/drivers/gpio/gpio-tps65218.c
+++ b/drivers/gpio/gpio-tps65218.c
@@ -59,6 +59,7 @@ static int tps65218_gpio_output(struct gpio_chip *gc, unsigned offset,
int value)
{
/* Only drives GPOs */
+ tps65218_gpio_set(gc, offset, value);
return 0;
}
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/2] gpio: tpic2810: Make tpic2810_direction_output set proper output level
2016-02-15 12:09 [PATCH 1/2] gpio: tpic2810: Make tpic2810_direction_output set proper output level Axel Lin
2016-02-15 12:10 ` [PATCH 2/2] gpio: tps65218: Make tps65218_gpio_output " Axel Lin
@ 2016-02-16 14:57 ` Linus Walleij
1 sibling, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2016-02-16 14:57 UTC (permalink / raw)
To: Axel Lin; +Cc: Andrew F. Davis, Alexandre Courbot, linux-gpio@vger.kernel.org
On Mon, Feb 15, 2016 at 1:09 PM, Axel Lin <axel.lin@ingics.com> wrote:
> The .direction_output callback should set proper output level.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Obviously correct. Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-02-16 14:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-15 12:09 [PATCH 1/2] gpio: tpic2810: Make tpic2810_direction_output set proper output level Axel Lin
2016-02-15 12:10 ` [PATCH 2/2] gpio: tps65218: Make tps65218_gpio_output " Axel Lin
2016-02-16 14:58 ` Linus Walleij
2016-02-16 14:57 ` [PATCH 1/2] gpio: tpic2810: Make tpic2810_direction_output " Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).