From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hongzhou Yang Subject: Re: [PATCH 2/8] drivers/pinctrl: make mediatek/pinctrl-mt6397 driver explicitly non-modular Date: Tue, 1 Mar 2016 12:02:01 -0800 Message-ID: <1456862521.13127.1.camel@mussux00> References: <1456778924-20730-1-git-send-email-paul.gortmaker@windriver.com> <1456778924-20730-3-git-send-email-paul.gortmaker@windriver.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1456778924-20730-3-git-send-email-paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Paul Gortmaker Cc: biao.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, Linus Walleij , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Matthias Brugger , yingjoe.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, eddie.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org List-Id: linux-gpio@vger.kernel.org On Mon, 2016-02-29 at 15:48 -0500, Paul Gortmaker wrote: > The Kconfig for this driver is currently: > > config PINCTRL_MT6397 > bool "Mediatek MT6397 pin control" if COMPILE_TEST && !MFD_MT6397 > > ...meaning that it is currently not being built as a module by anyone. > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. > > Since module_init translates to device_initcall in the non-modular > case, the init ordering remains unchanged with this commit. > > We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > Cc: Linus Walleij > Cc: Matthias Brugger > Cc: Hongzhou Yang > Cc: linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Cc: linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > Signed-off-by: Paul Gortmaker > --- > drivers/pinctrl/mediatek/pinctrl-mt6397.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/drivers/pinctrl/mediatek/pinctrl-mt6397.c b/drivers/pinctrl/mediatek/pinctrl-mt6397.c > index f9751ae28e32..6eccb85c02cd 100644 > --- a/drivers/pinctrl/mediatek/pinctrl-mt6397.c > +++ b/drivers/pinctrl/mediatek/pinctrl-mt6397.c > @@ -12,7 +12,7 @@ > * GNU General Public License for more details. > */ > > -#include > +#include > #include > #include > #include > @@ -55,7 +55,6 @@ static const struct of_device_id mt6397_pctrl_match[] = { > { .compatible = "mediatek,mt6397-pinctrl", }, > { } > }; > -MODULE_DEVICE_TABLE(of, mt6397_pctrl_match); > > static struct platform_driver mtk_pinctrl_driver = { > .probe = mt6397_pinctrl_probe, > @@ -69,9 +68,4 @@ static int __init mtk_pinctrl_init(void) > { > return platform_driver_register(&mtk_pinctrl_driver); > } > - > -module_init(mtk_pinctrl_init); > - > -MODULE_LICENSE("GPL v2"); > -MODULE_DESCRIPTION("MediaTek MT6397 Pinctrl Driver"); > -MODULE_AUTHOR("Hongzhou Yang "); > +device_initcall(mtk_pinctrl_init); Acked-by: Hongzhou Yang Thanks, Hongzhou