From: Matthias Brugger <mbrugger@suse.com>
To: linus.walleij@linaro.org, gnurou@gmail.com
Cc: qnguyen@apm.com, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org,
Matthias Brugger <mbrugger@suse.com>
Subject: [PATCH] gpio: xgene: Fix kconfig for standby GIPO contoller
Date: Fri, 4 Mar 2016 12:42:12 +0100 [thread overview]
Message-ID: <1457091732-21924-1-git-send-email-mbrugger@suse.com> (raw)
The standby GPIO controller can be used as a interrupt controller.
Select GPIOLIB_IRQCHIP when compiling this driver. Otherwise we get
a compilation error:
drivers/gpio/gpio-xgene-sb.c: In function 'xgene_gpio_sb_probe':
drivers/gpio/gpio-xgene-sb.c:312:10: error: 'struct gpio_chip' has no member named 'irqdomain'
priv->gc.irqdomain = priv->irq_domain;
^
scripts/Makefile.build:295: recipe for target 'drivers/gpio/gpio-xgene-sb.o' failed
make[2]: *** [drivers/gpio/gpio-xgene-sb.o] Error 1
Apart if compiled as module, we get the following modpost errors:
ERROR: "irq_chip_eoi_parent" [drivers/gpio/gpio-xgene-sb.ko] undefined!
ERROR: "irq_chip_unmask_parent" [drivers/gpio/gpio-xgene-sb.ko] undefined!
ERROR: "irq_chip_mask_parent" [drivers/gpio/gpio-xgene-sb.ko] undefined!
ERROR: "irq_domain_create_hierarchy" [drivers/gpio/gpio-xgene-sb.ko] undefined!
ERROR: "gpiochip_get_data" [drivers/gpio/gpio-xgene-sb.ko] undefined!
ERROR: "irq_chip_set_type_parent" [drivers/gpio/gpio-xgene-sb.ko] undefined!
ERROR: "irq_domain_alloc_irqs_parent" [drivers/gpio/gpio-xgene-sb.ko] undefined!
ERROR: "irq_domain_set_hwirq_and_chip" [drivers/gpio/gpio-xgene-sb.ko] undefined!
ERROR: "irq_domain_reset_irq_data" [drivers/gpio/gpio-xgene-sb.ko] undefined!
This patch changes the kconfig so that the gpio controller can only be
build-in and selects GPIOLIB_IRQCHIP.
Fixes: 1013fc41 "gpio: xgene: Enable X-Gene standby GPIO as interrupt controller"
Cc: Quan Nguyen <qnguyen@apm.com>
Signed-off-by: Matthias Brugger <mbrugger@suse.com>
---
Changes for v2:
- Add modprobe fix, changing tristate to bool
- Add Cc tag
drivers/gpio/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 619767b..ff67dc3 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -449,9 +449,10 @@ config GPIO_XGENE
here to enable the GFC GPIO functionality.
config GPIO_XGENE_SB
- tristate "APM X-Gene GPIO standby controller support"
+ bool "APM X-Gene GPIO standby controller support"
depends on ARCH_XGENE && OF_GPIO
select GPIO_GENERIC
+ select GPIOLIB_IRQCHIP
help
This driver supports the GPIO block within the APM X-Gene
Standby Domain. Say yes here to enable the GPIO functionality.
--
2.6.2
next reply other threads:[~2016-03-04 11:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-04 11:42 Matthias Brugger [this message]
2016-03-07 7:41 ` [PATCH] gpio: xgene: Fix kconfig for standby GIPO contoller Linus Walleij
2016-03-07 10:47 ` Matthias Brugger
2016-03-08 4:43 ` Quan Nguyen
-- strict thread matches above, loose matches on Subject: below --
2016-03-04 10:59 Matthias Brugger
2016-03-08 4:29 ` Quan Nguyen
2016-03-11 16:01 ` Linus Walleij
2016-03-11 20:03 ` Matthias Brugger
2016-03-16 12:00 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457091732-21924-1-git-send-email-mbrugger@suse.com \
--to=mbrugger@suse.com \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qnguyen@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).