* [PATCH] gpio: brcmstb: Return proper error if bank width is invalid
@ 2016-04-10 10:15 Axel Lin
2016-04-12 22:59 ` Gregory Fong
2016-04-15 8:10 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2016-04-10 10:15 UTC (permalink / raw)
To: Linus Walleij
Cc: Gregory Fong, Alexandre Courbot, bcm-kernel-feedback-list,
linux-gpio
Return proper error in brcmstb_gpio_probe if bank width is invalid.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/gpio/gpio-brcmstb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/gpio-brcmstb.c b/drivers/gpio/gpio-brcmstb.c
index 42d51c5..e648914 100644
--- a/drivers/gpio/gpio-brcmstb.c
+++ b/drivers/gpio/gpio-brcmstb.c
@@ -461,6 +461,7 @@ static int brcmstb_gpio_probe(struct platform_device *pdev)
bank->id = num_banks;
if (bank_width <= 0 || bank_width > MAX_GPIO_PER_BANK) {
dev_err(dev, "Invalid bank width %d\n", bank_width);
+ err = -EINVAL;
goto fail;
} else {
bank->width = bank_width;
--
2.5.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] gpio: brcmstb: Return proper error if bank width is invalid
2016-04-10 10:15 [PATCH] gpio: brcmstb: Return proper error if bank width is invalid Axel Lin
@ 2016-04-12 22:59 ` Gregory Fong
2016-04-15 8:10 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Gregory Fong @ 2016-04-12 22:59 UTC (permalink / raw)
To: Axel Lin
Cc: Linus Walleij, Alexandre Courbot, bcm-kernel-feedback-list,
linux-gpio
On Sun, Apr 10, 2016 at 3:15 AM, Axel Lin <axel.lin@ingics.com> wrote:
> Return proper error in brcmstb_gpio_probe if bank width is invalid.
Thanks for catching that.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Gregory Fong <gregory.0xf0@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: brcmstb: Return proper error if bank width is invalid
2016-04-10 10:15 [PATCH] gpio: brcmstb: Return proper error if bank width is invalid Axel Lin
2016-04-12 22:59 ` Gregory Fong
@ 2016-04-15 8:10 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2016-04-15 8:10 UTC (permalink / raw)
To: Axel Lin
Cc: Gregory Fong, Alexandre Courbot, bcm-kernel-feedback-list,
linux-gpio@vger.kernel.org
On Sun, Apr 10, 2016 at 12:15 PM, Axel Lin <axel.lin@ingics.com> wrote:
> Return proper error in brcmstb_gpio_probe if bank width is invalid.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Patch applied with Gregory's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-04-15 8:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-10 10:15 [PATCH] gpio: brcmstb: Return proper error if bank width is invalid Axel Lin
2016-04-12 22:59 ` Gregory Fong
2016-04-15 8:10 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).