From: Arnd Bergmann <arnd@arndb.de>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
Arnd Bergmann <arnd@arndb.de>, Frank Li <Frank.Li@freescale.com>,
Anson Huang <b20788@freescale.com>,
Shawn Guo <shawnguo@kernel.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] pinctrl: imx: select regmap subsystem
Date: Sat, 16 Apr 2016 22:26:06 +0200 [thread overview]
Message-ID: <1460838382-1245338-1-git-send-email-arnd@arndb.de> (raw)
Building the imx pinctrl driver without regmap fails with multiple
build errors like:
drivers/pinctrl/freescale/pinctrl-imx.c: In function 'imx_pinctrl_probe':
drivers/pinctrl/freescale/pinctrl-imx.c:723:9: error: variable 'config' has initializer but incomplete type
struct regmap_config config = { .name = "gpr" };
This adds a 'select REGMAP' statement, to ensure we can define a 'struct
regmap_config'. This matches what all other regmap users do. The driver
actually uses syscon on top of regmap, but syscon is already enabled
on i.MX for other reasons, and selecting REGMAP but not SYSCON is
sufficient for build testing on other platforms.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 8626ada871f1 ("pinctrl: imx: attach iomuxc device to gpr syscon")
---
drivers/pinctrl/freescale/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/freescale/Kconfig b/drivers/pinctrl/freescale/Kconfig
index debe1219d76d..fc8cbf611723 100644
--- a/drivers/pinctrl/freescale/Kconfig
+++ b/drivers/pinctrl/freescale/Kconfig
@@ -2,6 +2,7 @@ config PINCTRL_IMX
bool
select PINMUX
select PINCONF
+ select REGMAP
config PINCTRL_IMX1_CORE
bool
--
2.7.0
next reply other threads:[~2016-04-16 20:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-16 20:26 Arnd Bergmann [this message]
2016-04-18 1:44 ` [PATCH] pinctrl: imx: select regmap subsystem Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460838382-1245338-1-git-send-email-arnd@arndb.de \
--to=arnd@arndb.de \
--cc=Frank.Li@freescale.com \
--cc=b20788@freescale.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).