From mboxrd@z Thu Jan 1 00:00:00 1970 From: chunfeng yun Subject: Re: [PATCH 3/6] dt-bindings: mtu3: add devicetree bindings Date: Fri, 13 May 2016 10:00:20 +0800 Message-ID: <1463104820.11651.125.camel@mhfsdcap03> References: <1462868614-20602-1-git-send-email-chunfeng.yun@mediatek.com> <1462868614-20602-4-git-send-email-chunfeng.yun@mediatek.com> <20160511145409.GA23042@rob-hp-laptop> <1463037844.11651.118.camel@mhfsdcap03> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from mailgw01.mediatek.com ([218.249.47.110]:46083 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751576AbcEMCAa (ORCPT ); Thu, 12 May 2016 22:00:30 -0400 In-Reply-To: Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Alan Cooper Cc: Rob Herring , Greg Kroah-Hartman , Felipe Balbi , Mathias Nyman , Alan Stern , Mark Rutland , Ian Campbell , Matthias Brugger , Sergei Shtylyov , Pawel Moll , Kumar Gala , Sascha Hauer , Linus Walleij , Biao Huang , USB list , "devicetree@vger.kernel.org" , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org Hi, On Thu, 2016-05-12 at 19:02 -0400, Alan Cooper wrote: > On Thu, May 12, 2016 at 3:24 AM, chunfeng yun wrote: > >> > + - mediatek,enable-manual-drd : supports manual dual-role switch by sysfs > >> > + interface; only used when receptacle is TYPE-A and also wants to support > >> > + dual-role mode. > >> > >> sysfs is a Linux detail that doesn't apply to the binding. Does the > >> property mean "the IP block supports or doesn't support switching" or > >> "I want to enable switching feature". Only the former belongs in DT. > >> > > It is the former case, and has little relation with sysfs interface. > > I will modify it later, sorry for my unclear description. > > Could the property name be just "enable-manual-drd" instead of > "mediatek,enable-manual-drd"? I expect to have to add this > functionality to our USB driver in the near future. Do you mean provide some APIs to in common USB driver?