* [PATCH] gpiolib-acpi: add _DEP support for Acer One 10
@ 2016-05-16 3:18 Zhang, Rui
2016-06-14 7:33 ` Linus Walleij
2016-06-15 6:49 ` Linus Walleij
0 siblings, 2 replies; 6+ messages in thread
From: Zhang, Rui @ 2016-05-16 3:18 UTC (permalink / raw)
To: linux-gpio@vger.kernel.org
Cc: linux-acpi, mika.westerberg@linux.intel.com, stace75@gmail.com,
Wysocki, Rafael J
From 8590bdcacc94a1ab260b4ea2e6e747b0bc1d9bf8 Mon Sep 17 00:00:00 2001
From: Zhang Rui <rui.zhang@intel.com>
Date: Wed, 11 May 2016 09:02:28 +0800
Subject: [PATCH] gpiolib-acpi: add _DEP support for Acer One 10
On Acer One 10, the ACPI battery driver can not be probed because
it depends on the GPIO controller as well as the I2C controller to work,
Device (BATC)
{
Name (_HID, EisaId ("PNP0C0A") /* Control Method Battery */)
...
Name (_DEP, Package (0x03) // _DEP: Dependencies
{
I2C1,
GPO2,
GPO0
})
...
}
The I2C dependency also exists on other platforms and has been fixed by commit
40e7fcb19293 ("ACPI: Add _DEP support to fix battery issue on Asus T100TA"),
this patch resolves the GPIO dependency for Acer One 10.
Link:https://bugzilla.kernel.org/show_bug.cgi?id=115191
CC: Mika Westerberg <mika.westerberg@linux.intel.com>
CC: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Tested-by: Stace A. Zacharov <stace75@gmail.com>
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
---
drivers/gpio/gpiolib-acpi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
index 682070d..4b809b0 100644
--- a/drivers/gpio/gpiolib-acpi.c
+++ b/drivers/gpio/gpiolib-acpi.c
@@ -836,6 +836,7 @@ void acpi_gpiochip_add(struct gpio_chip *chip)
}
acpi_gpiochip_request_regions(acpi_gpio);
+ acpi_walk_dep_device_list(handle);
}
void acpi_gpiochip_remove(struct gpio_chip *chip)
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] gpiolib-acpi: add _DEP support for Acer One 10
2016-05-16 3:18 [PATCH] gpiolib-acpi: add _DEP support for Acer One 10 Zhang, Rui
@ 2016-06-14 7:33 ` Linus Walleij
2016-06-14 10:01 ` Mika Westerberg
2016-06-15 6:49 ` Linus Walleij
1 sibling, 1 reply; 6+ messages in thread
From: Linus Walleij @ 2016-06-14 7:33 UTC (permalink / raw)
To: Zhang, Rui, Mika Westerberg, Rafael J. Wysocki
Cc: linux-gpio@vger.kernel.org, linux-acpi, stace75@gmail.com
Mika, Rafael: this came from Intel, can you review it? Should it be applied?
Yours,
Linus Walleij
On Mon, May 16, 2016 at 5:18 AM, Zhang, Rui <rui.zhang@intel.com> wrote:
> From 8590bdcacc94a1ab260b4ea2e6e747b0bc1d9bf8 Mon Sep 17 00:00:00 2001
> From: Zhang Rui <rui.zhang@intel.com>
> Date: Wed, 11 May 2016 09:02:28 +0800
> Subject: [PATCH] gpiolib-acpi: add _DEP support for Acer One 10
>
> On Acer One 10, the ACPI battery driver can not be probed because
> it depends on the GPIO controller as well as the I2C controller to work,
> Device (BATC)
> {
> Name (_HID, EisaId ("PNP0C0A") /* Control Method Battery */)
> ...
> Name (_DEP, Package (0x03) // _DEP: Dependencies
> {
> I2C1,
> GPO2,
> GPO0
> })
> ...
> }
>
> The I2C dependency also exists on other platforms and has been fixed by commit
> 40e7fcb19293 ("ACPI: Add _DEP support to fix battery issue on Asus T100TA"),
> this patch resolves the GPIO dependency for Acer One 10.
>
> Link:https://bugzilla.kernel.org/show_bug.cgi?id=115191
> CC: Mika Westerberg <mika.westerberg@linux.intel.com>
> CC: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Tested-by: Stace A. Zacharov <stace75@gmail.com>
> Signed-off-by: Zhang Rui <rui.zhang@intel.com>
> ---
> drivers/gpio/gpiolib-acpi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
> index 682070d..4b809b0 100644
> --- a/drivers/gpio/gpiolib-acpi.c
> +++ b/drivers/gpio/gpiolib-acpi.c
> @@ -836,6 +836,7 @@ void acpi_gpiochip_add(struct gpio_chip *chip)
> }
>
> acpi_gpiochip_request_regions(acpi_gpio);
> + acpi_walk_dep_device_list(handle);
> }
>
> void acpi_gpiochip_remove(struct gpio_chip *chip)
> --
> 1.9.1
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] gpiolib-acpi: add _DEP support for Acer One 10
2016-06-14 7:33 ` Linus Walleij
@ 2016-06-14 10:01 ` Mika Westerberg
2016-06-14 21:38 ` Rafael J. Wysocki
0 siblings, 1 reply; 6+ messages in thread
From: Mika Westerberg @ 2016-06-14 10:01 UTC (permalink / raw)
To: Linus Walleij
Cc: Zhang, Rui, Rafael J. Wysocki, linux-gpio@vger.kernel.org,
linux-acpi, stace75@gmail.com
On Tue, Jun 14, 2016 at 09:33:30AM +0200, Linus Walleij wrote:
> Mika, Rafael: this came from Intel, can you review it? Should it be applied?
Looks reasonable so unless Rafael objects you can add my,
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
>
> Yours,
> Linus Walleij
>
> On Mon, May 16, 2016 at 5:18 AM, Zhang, Rui <rui.zhang@intel.com> wrote:
>
> > From 8590bdcacc94a1ab260b4ea2e6e747b0bc1d9bf8 Mon Sep 17 00:00:00 2001
> > From: Zhang Rui <rui.zhang@intel.com>
> > Date: Wed, 11 May 2016 09:02:28 +0800
> > Subject: [PATCH] gpiolib-acpi: add _DEP support for Acer One 10
> >
> > On Acer One 10, the ACPI battery driver can not be probed because
> > it depends on the GPIO controller as well as the I2C controller to work,
> > Device (BATC)
> > {
> > Name (_HID, EisaId ("PNP0C0A") /* Control Method Battery */)
> > ...
> > Name (_DEP, Package (0x03) // _DEP: Dependencies
> > {
> > I2C1,
> > GPO2,
> > GPO0
> > })
> > ...
> > }
> >
> > The I2C dependency also exists on other platforms and has been fixed by commit
> > 40e7fcb19293 ("ACPI: Add _DEP support to fix battery issue on Asus T100TA"),
> > this patch resolves the GPIO dependency for Acer One 10.
> >
> > Link:https://bugzilla.kernel.org/show_bug.cgi?id=115191
> > CC: Mika Westerberg <mika.westerberg@linux.intel.com>
> > CC: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > Tested-by: Stace A. Zacharov <stace75@gmail.com>
> > Signed-off-by: Zhang Rui <rui.zhang@intel.com>
> > ---
> > drivers/gpio/gpiolib-acpi.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
> > index 682070d..4b809b0 100644
> > --- a/drivers/gpio/gpiolib-acpi.c
> > +++ b/drivers/gpio/gpiolib-acpi.c
> > @@ -836,6 +836,7 @@ void acpi_gpiochip_add(struct gpio_chip *chip)
> > }
> >
> > acpi_gpiochip_request_regions(acpi_gpio);
> > + acpi_walk_dep_device_list(handle);
> > }
> >
> > void acpi_gpiochip_remove(struct gpio_chip *chip)
> > --
> > 1.9.1
> >
> >
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] gpiolib-acpi: add _DEP support for Acer One 10
2016-06-14 10:01 ` Mika Westerberg
@ 2016-06-14 21:38 ` Rafael J. Wysocki
0 siblings, 0 replies; 6+ messages in thread
From: Rafael J. Wysocki @ 2016-06-14 21:38 UTC (permalink / raw)
To: Mika Westerberg, Linus Walleij
Cc: Zhang, Rui, linux-gpio@vger.kernel.org, linux-acpi,
stace75@gmail.com
On 6/14/2016 12:01 PM, Mika Westerberg wrote:
> On Tue, Jun 14, 2016 at 09:33:30AM +0200, Linus Walleij wrote:
>> Mika, Rafael: this came from Intel, can you review it? Should it be applied?
> Looks reasonable so unless Rafael objects you can add my,
>
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
No objections.
>> Yours,
>> Linus Walleij
>>
>> On Mon, May 16, 2016 at 5:18 AM, Zhang, Rui <rui.zhang@intel.com> wrote:
>>
>>> From 8590bdcacc94a1ab260b4ea2e6e747b0bc1d9bf8 Mon Sep 17 00:00:00 2001
>>> From: Zhang Rui <rui.zhang@intel.com>
>>> Date: Wed, 11 May 2016 09:02:28 +0800
>>> Subject: [PATCH] gpiolib-acpi: add _DEP support for Acer One 10
>>>
>>> On Acer One 10, the ACPI battery driver can not be probed because
>>> it depends on the GPIO controller as well as the I2C controller to work,
>>> Device (BATC)
>>> {
>>> Name (_HID, EisaId ("PNP0C0A") /* Control Method Battery */)
>>> ...
>>> Name (_DEP, Package (0x03) // _DEP: Dependencies
>>> {
>>> I2C1,
>>> GPO2,
>>> GPO0
>>> })
>>> ...
>>> }
>>>
>>> The I2C dependency also exists on other platforms and has been fixed by commit
>>> 40e7fcb19293 ("ACPI: Add _DEP support to fix battery issue on Asus T100TA"),
>>> this patch resolves the GPIO dependency for Acer One 10.
>>>
>>> Link:https://bugzilla.kernel.org/show_bug.cgi?id=115191
>>> CC: Mika Westerberg <mika.westerberg@linux.intel.com>
>>> CC: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>>> Tested-by: Stace A. Zacharov <stace75@gmail.com>
>>> Signed-off-by: Zhang Rui <rui.zhang@intel.com>
>>> ---
>>> drivers/gpio/gpiolib-acpi.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
>>> index 682070d..4b809b0 100644
>>> --- a/drivers/gpio/gpiolib-acpi.c
>>> +++ b/drivers/gpio/gpiolib-acpi.c
>>> @@ -836,6 +836,7 @@ void acpi_gpiochip_add(struct gpio_chip *chip)
>>> }
>>>
>>> acpi_gpiochip_request_regions(acpi_gpio);
>>> + acpi_walk_dep_device_list(handle);
>>> }
>>>
>>> void acpi_gpiochip_remove(struct gpio_chip *chip)
>>> --
>>> 1.9.1
>>>
>>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] gpiolib-acpi: add _DEP support for Acer One 10
2016-05-16 3:18 [PATCH] gpiolib-acpi: add _DEP support for Acer One 10 Zhang, Rui
2016-06-14 7:33 ` Linus Walleij
@ 2016-06-15 6:49 ` Linus Walleij
2016-06-16 1:51 ` Zhang Rui
1 sibling, 1 reply; 6+ messages in thread
From: Linus Walleij @ 2016-06-15 6:49 UTC (permalink / raw)
To: Zhang, Rui
Cc: linux-gpio@vger.kernel.org, linux-acpi,
mika.westerberg@linux.intel.com, stace75@gmail.com,
Wysocki, Rafael J
On Mon, May 16, 2016 at 5:18 AM, Zhang, Rui <rui.zhang@intel.com> wrote:
> On Acer One 10, the ACPI battery driver can not be probed because
> it depends on the GPIO controller as well as the I2C controller to work,
> Device (BATC)
> {
> Name (_HID, EisaId ("PNP0C0A") /* Control Method Battery */)
> ...
> Name (_DEP, Package (0x03) // _DEP: Dependencies
> {
> I2C1,
> GPO2,
> GPO0
> })
> ...
> }
>
> The I2C dependency also exists on other platforms and has been fixed by commit
> 40e7fcb19293 ("ACPI: Add _DEP support to fix battery issue on Asus T100TA"),
> this patch resolves the GPIO dependency for Acer One 10.
>
> Link:https://bugzilla.kernel.org/show_bug.cgi?id=115191
> CC: Mika Westerberg <mika.westerberg@linux.intel.com>
> CC: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Tested-by: Stace A. Zacharov <stace75@gmail.com>
> Signed-off-by: Zhang Rui <rui.zhang@intel.com>
Patch applied with the ACKs.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] gpiolib-acpi: add _DEP support for Acer One 10
2016-06-15 6:49 ` Linus Walleij
@ 2016-06-16 1:51 ` Zhang Rui
0 siblings, 0 replies; 6+ messages in thread
From: Zhang Rui @ 2016-06-16 1:51 UTC (permalink / raw)
To: Linus Walleij
Cc: linux-gpio@vger.kernel.org, linux-acpi,
mika.westerberg@linux.intel.com, stace75@gmail.com,
Wysocki, Rafael J
On 三, 2016-06-15 at 08:49 +0200, Linus Walleij wrote:
> On Mon, May 16, 2016 at 5:18 AM, Zhang, Rui <rui.zhang@intel.com>
> wrote:
>
> >
> > On Acer One 10, the ACPI battery driver can not be probed because
> > it depends on the GPIO controller as well as the I2C controller to
> > work,
> > Device (BATC)
> > {
> > Name (_HID, EisaId ("PNP0C0A") /* Control Method
> > Battery */)
> > ...
> > Name (_DEP, Package (0x03) // _DEP: Dependencies
> > {
> > I2C1,
> > GPO2,
> > GPO0
> > })
> > ...
> > }
> >
> > The I2C dependency also exists on other platforms and has been
> > fixed by commit
> > 40e7fcb19293 ("ACPI: Add _DEP support to fix battery issue on Asus
> > T100TA"),
> > this patch resolves the GPIO dependency for Acer One 10.
> >
> > Link:https://bugzilla.kernel.org/show_bug.cgi?id=115191
> > CC: Mika Westerberg <mika.westerberg@linux.intel.com>
> > CC: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > Tested-by: Stace A. Zacharov <stace75@gmail.com>
> > Signed-off-by: Zhang Rui <rui.zhang@intel.com>
> Patch applied with the ACKs.
>
Thanks for taking the patch.
-rui
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-06-16 1:51 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-16 3:18 [PATCH] gpiolib-acpi: add _DEP support for Acer One 10 Zhang, Rui
2016-06-14 7:33 ` Linus Walleij
2016-06-14 10:01 ` Mika Westerberg
2016-06-14 21:38 ` Rafael J. Wysocki
2016-06-15 6:49 ` Linus Walleij
2016-06-16 1:51 ` Zhang Rui
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).