* [PATCH] pinctrl: imx: Do not treat a PIN without MUX register as an error
@ 2016-06-01 19:21 Alexander Shiyan
2016-06-08 7:52 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Shiyan @ 2016-06-01 19:21 UTC (permalink / raw)
To: linux-gpio
Cc: Linus Walleij, Shawn Guo, Adrian Alonso, Philipp Zabel,
Alexander Shiyan
Some PINs do not have a MUX register, it is not an error.
It is necessary to allow the continuation of the PINs configuration,
otherwise the whole PIN-group will be configured incorrectly.
Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
drivers/pinctrl/freescale/pinctrl-imx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c b/drivers/pinctrl/freescale/pinctrl-imx.c
index 47ccfcc..eccb474 100644
--- a/drivers/pinctrl/freescale/pinctrl-imx.c
+++ b/drivers/pinctrl/freescale/pinctrl-imx.c
@@ -209,9 +209,9 @@ static int imx_pmx_set(struct pinctrl_dev *pctldev, unsigned selector,
pin_reg = &info->pin_regs[pin_id];
if (pin_reg->mux_reg == -1) {
- dev_err(ipctl->dev, "Pin(%s) does not support mux function\n",
+ dev_dbg(ipctl->dev, "Pin(%s) does not support mux function\n",
info->pins[pin_id].name);
- return -EINVAL;
+ continue;
}
if (info->flags & SHARE_MUX_CONF_REG) {
--
2.4.9
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: imx: Do not treat a PIN without MUX register as an error
2016-06-01 19:21 [PATCH] pinctrl: imx: Do not treat a PIN without MUX register as an error Alexander Shiyan
@ 2016-06-08 7:52 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2016-06-08 7:52 UTC (permalink / raw)
To: Alexander Shiyan
Cc: linux-gpio@vger.kernel.org, Shawn Guo, Adrian Alonso,
Philipp Zabel
On Wed, Jun 1, 2016 at 9:21 PM, Alexander Shiyan <shc_work@mail.ru> wrote:
> Some PINs do not have a MUX register, it is not an error.
> It is necessary to allow the continuation of the PINs configuration,
> otherwise the whole PIN-group will be configured incorrectly.
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
No reply from the i.MX maintainers for a week but the issue seems
serious so I have applied it for fixes and tagged for stable.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-08 7:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-01 19:21 [PATCH] pinctrl: imx: Do not treat a PIN without MUX register as an error Alexander Shiyan
2016-06-08 7:52 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).