[PATCH] pinctrl: imx: Do not treat a PIN without MUX register as an error

[PATCH] pinctrl: imx: Do not treat a PIN without MUX register as an error

[Alexander Shiyan]

Some PINs do not have a MUX register, it is not an error.
It is necessary to allow the continuation of the PINs configuration,
otherwise the whole PIN-group will be configured incorrectly.

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 drivers/pinctrl/freescale/pinctrl-imx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c b/drivers/pinctrl/freescale/pinctrl-imx.c
index 47ccfcc..eccb474 100644
--- a/drivers/pinctrl/freescale/pinctrl-imx.c
+++ b/drivers/pinctrl/freescale/pinctrl-imx.c
@@ -209,9 +209,9 @@ static int imx_pmx_set(struct pinctrl_dev *pctldev, unsigned selector,
 		pin_reg = &info->pin_regs[pin_id];
 
 		if (pin_reg->mux_reg == -1) {
-			dev_err(ipctl->dev, "Pin(%s) does not support mux function\n",
+			dev_dbg(ipctl->dev, "Pin(%s) does not support mux function\n",
 				info->pins[pin_id].name);
-			return -EINVAL;
+			continue;
 		}
 
 		if (info->flags & SHARE_MUX_CONF_REG) {
-- 
2.4.9

Re: [PATCH] pinctrl: imx: Do not treat a PIN without MUX register as an error

[Linus Walleij]

On Wed, Jun 1, 2016 at 9:21 PM, Alexander Shiyan <shc_work@mail.ru> wrote:

> Some PINs do not have a MUX register, it is not an error.
> It is necessary to allow the continuation of the PINs configuration,
> otherwise the whole PIN-group will be configured incorrectly.
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>

No reply from the i.MX maintainers for a week but the issue seems
serious so I have applied it for fixes and tagged for stable.

Yours,
Linus Walleij