* [PATCH v1 1/1] gpio: lynxpoint: avoid potential warning on error path
@ 2016-06-19 16:06 Andy Shevchenko
2016-06-20 9:05 ` Mika Westerberg
2016-06-23 8:04 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Andy Shevchenko @ 2016-06-19 16:06 UTC (permalink / raw)
To: linux-gpio, Linus Walleij, Mika Westerberg; +Cc: Andy Shevchenko
When devres API is in use we are not supposed to call plain gpiochip_remove().
Remove redundant call to gpiochip_remove().
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/gpio/gpio-lynxpoint.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpio/gpio-lynxpoint.c b/drivers/gpio/gpio-lynxpoint.c
index 9df015e..fbd393b 100644
--- a/drivers/gpio/gpio-lynxpoint.c
+++ b/drivers/gpio/gpio-lynxpoint.c
@@ -383,7 +383,6 @@ static int lp_gpio_probe(struct platform_device *pdev)
handle_simple_irq, IRQ_TYPE_NONE);
if (ret) {
dev_err(dev, "failed to add irqchip\n");
- gpiochip_remove(gc);
return ret;
}
--
2.8.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] gpio: lynxpoint: avoid potential warning on error path
2016-06-19 16:06 [PATCH v1 1/1] gpio: lynxpoint: avoid potential warning on error path Andy Shevchenko
@ 2016-06-20 9:05 ` Mika Westerberg
2016-06-23 8:04 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Mika Westerberg @ 2016-06-20 9:05 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: linux-gpio, Linus Walleij
On Sun, Jun 19, 2016 at 07:06:44PM +0300, Andy Shevchenko wrote:
> When devres API is in use we are not supposed to call plain gpiochip_remove().
> Remove redundant call to gpiochip_remove().
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Good catch!
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] gpio: lynxpoint: avoid potential warning on error path
2016-06-19 16:06 [PATCH v1 1/1] gpio: lynxpoint: avoid potential warning on error path Andy Shevchenko
2016-06-20 9:05 ` Mika Westerberg
@ 2016-06-23 8:04 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2016-06-23 8:04 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: linux-gpio@vger.kernel.org, Mika Westerberg
On Sun, Jun 19, 2016 at 6:06 PM, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> When devres API is in use we are not supposed to call plain gpiochip_remove().
> Remove redundant call to gpiochip_remove().
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Patch applied with Mika's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-23 8:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-19 16:06 [PATCH v1 1/1] gpio: lynxpoint: avoid potential warning on error path Andy Shevchenko
2016-06-20 9:05 ` Mika Westerberg
2016-06-23 8:04 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).