* [PATCH] pinctrl: rockchip: make rockchip_irq_gc_mask_set_bit static
@ 2016-06-21 17:38 Ben Dooks
2016-06-23 8:49 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Ben Dooks @ 2016-06-21 17:38 UTC (permalink / raw)
To: linux-kernel
Cc: Ben Dooks, Linus Walleij, Heiko Stuebner, linux-gpio,
linux-arm-kernel, linux-rockchip
The rockchip_irq_gc_mask_set_bit() function is not exported our used
outside of ppinctrl-rockchip.c so fix the following sparse error by
making it static:
drivers/pinctrl/pinctrl-rockchip.c:2010:6: warning: symbol 'rockchip_irq_gc_mask_set_bit' was not declared. Should it be static?
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: linux-gpio@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-rockchip@lists.infradead.org
---
drivers/pinctrl/pinctrl-rockchip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c
index a91026e..7d679c2 100644
--- a/drivers/pinctrl/pinctrl-rockchip.c
+++ b/drivers/pinctrl/pinctrl-rockchip.c
@@ -2007,7 +2007,7 @@ static void rockchip_irq_gc_mask_clr_bit(struct irq_data *d)
irq_gc_mask_clr_bit(d);
}
-void rockchip_irq_gc_mask_set_bit(struct irq_data *d)
+static void rockchip_irq_gc_mask_set_bit(struct irq_data *d)
{
struct irq_chip_generic *gc = irq_data_get_irq_chip_data(d);
struct rockchip_pin_bank *bank = gc->private;
--
2.8.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: rockchip: make rockchip_irq_gc_mask_set_bit static
2016-06-21 17:38 [PATCH] pinctrl: rockchip: make rockchip_irq_gc_mask_set_bit static Ben Dooks
@ 2016-06-23 8:49 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2016-06-23 8:49 UTC (permalink / raw)
To: Ben Dooks
Cc: linux-kernel, Heiko Stuebner, linux-gpio@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
open list:ARM/Rockchip SoC...
On Tue, Jun 21, 2016 at 7:38 PM, Ben Dooks <ben.dooks@codethink.co.uk> wrote:
> The rockchip_irq_gc_mask_set_bit() function is not exported our used
> outside of ppinctrl-rockchip.c so fix the following sparse error by
> making it static:
>
> drivers/pinctrl/pinctrl-rockchip.c:2010:6: warning: symbol 'rockchip_irq_gc_mask_set_bit' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Patch applied as obviously correct.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-23 8:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-21 17:38 [PATCH] pinctrl: rockchip: make rockchip_irq_gc_mask_set_bit static Ben Dooks
2016-06-23 8:49 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).