* [PATCH -next] pinctrl: nsp: remove redundant dev_err call in nsp_pinmux_probe()
@ 2016-07-06 12:02 weiyj_lk
2016-07-06 16:21 ` Ray Jui
2016-07-11 7:55 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: weiyj_lk @ 2016-07-06 12:02 UTC (permalink / raw)
To: Linus Walleij, Ray Jui, Scott Branden, Jon Mason
Cc: Wei Yongjun, linux-gpio, linux-arm-kernel,
bcm-kernel-feedback-list
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/pinctrl/bcm/pinctrl-nsp-mux.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/pinctrl/bcm/pinctrl-nsp-mux.c b/drivers/pinctrl/bcm/pinctrl-nsp-mux.c
index 7df0880b..4149db3 100644
--- a/drivers/pinctrl/bcm/pinctrl-nsp-mux.c
+++ b/drivers/pinctrl/bcm/pinctrl-nsp-mux.c
@@ -573,10 +573,8 @@ static int nsp_pinmux_probe(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
pinctrl->base0 = devm_ioremap_resource(&pdev->dev, res);
- if (IS_ERR(pinctrl->base0)) {
- dev_err(&pdev->dev, "unable to map I/O space\n");
+ if (IS_ERR(pinctrl->base0))
return PTR_ERR(pinctrl->base0);
- }
res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
pinctrl->base1 = devm_ioremap_nocache(&pdev->dev, res->start,
@@ -588,10 +586,8 @@ static int nsp_pinmux_probe(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 2);
pinctrl->base2 = devm_ioremap_resource(&pdev->dev, res);
- if (IS_ERR(pinctrl->base2)) {
- dev_err(&pdev->dev, "unable to map I/O space\n");
+ if (IS_ERR(pinctrl->base2))
return PTR_ERR(pinctrl->base2);
- }
ret = nsp_mux_log_init(pinctrl);
if (ret) {
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] pinctrl: nsp: remove redundant dev_err call in nsp_pinmux_probe()
2016-07-06 12:02 [PATCH -next] pinctrl: nsp: remove redundant dev_err call in nsp_pinmux_probe() weiyj_lk
@ 2016-07-06 16:21 ` Ray Jui
2016-07-11 7:55 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Ray Jui @ 2016-07-06 16:21 UTC (permalink / raw)
To: weiyj_lk, Linus Walleij, Ray Jui, Scott Branden, Jon Mason
Cc: Wei Yongjun, linux-gpio, linux-arm-kernel,
bcm-kernel-feedback-list
Hi Wei,
On 7/6/2016 5:02 AM, weiyj_lk@163.com wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/pinctrl/bcm/pinctrl-nsp-mux.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/pinctrl/bcm/pinctrl-nsp-mux.c b/drivers/pinctrl/bcm/pinctrl-nsp-mux.c
> index 7df0880b..4149db3 100644
> --- a/drivers/pinctrl/bcm/pinctrl-nsp-mux.c
> +++ b/drivers/pinctrl/bcm/pinctrl-nsp-mux.c
> @@ -573,10 +573,8 @@ static int nsp_pinmux_probe(struct platform_device *pdev)
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> pinctrl->base0 = devm_ioremap_resource(&pdev->dev, res);
> - if (IS_ERR(pinctrl->base0)) {
> - dev_err(&pdev->dev, "unable to map I/O space\n");
> + if (IS_ERR(pinctrl->base0))
> return PTR_ERR(pinctrl->base0);
> - }
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
> pinctrl->base1 = devm_ioremap_nocache(&pdev->dev, res->start,
> @@ -588,10 +586,8 @@ static int nsp_pinmux_probe(struct platform_device *pdev)
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 2);
> pinctrl->base2 = devm_ioremap_resource(&pdev->dev, res);
> - if (IS_ERR(pinctrl->base2)) {
> - dev_err(&pdev->dev, "unable to map I/O space\n");
> + if (IS_ERR(pinctrl->base2))
> return PTR_ERR(pinctrl->base2);
> - }
>
> ret = nsp_mux_log_init(pinctrl);
> if (ret) {
>
>
>
>
Looks good to me. Thanks!
Acked-by: Ray Jui <ray.jui@broadcom.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] pinctrl: nsp: remove redundant dev_err call in nsp_pinmux_probe()
2016-07-06 12:02 [PATCH -next] pinctrl: nsp: remove redundant dev_err call in nsp_pinmux_probe() weiyj_lk
2016-07-06 16:21 ` Ray Jui
@ 2016-07-11 7:55 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2016-07-11 7:55 UTC (permalink / raw)
To: weiyj_lk
Cc: Ray Jui, Scott Branden, Jon Mason, Wei Yongjun,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
bcm-kernel-feedback-list
On Wed, Jul 6, 2016 at 2:02 PM, <weiyj_lk@163.com> wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Patch applied with Ray's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-07-11 7:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-06 12:02 [PATCH -next] pinctrl: nsp: remove redundant dev_err call in nsp_pinmux_probe() weiyj_lk
2016-07-06 16:21 ` Ray Jui
2016-07-11 7:55 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).