* [PATCH] pinctrl: imx21: Remove the MODULE_DEVICE_TABLE() macro
@ 2016-07-06 13:25 Fabio Estevam
2016-07-06 13:42 ` Linus Walleij
2016-07-06 13:43 ` Arnd Bergmann
0 siblings, 2 replies; 5+ messages in thread
From: Fabio Estevam @ 2016-07-06 13:25 UTC (permalink / raw)
To: linus.walleij; +Cc: paul.gortmaker, arnd, linux-gpio, Fabio Estevam
Commit e2756baa4217 ("pinctrl: imx21: make it explicitly non-modular")
missed the removal of the MODULE_DEVICE_TABLE() macro causing the
following build error:
drivers/pinctrl/freescale/pinctrl-imx21.c:328:1: error: data definition has no type or storage class [-Werror]
MODULE_DEVICE_TABLE(of, imx21_pinctrl_of_match);
,so remove the macro to fix this problem.
Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
drivers/pinctrl/freescale/pinctrl-imx21.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pinctrl/freescale/pinctrl-imx21.c b/drivers/pinctrl/freescale/pinctrl-imx21.c
index b9f9b3b..73e26bc 100644
--- a/drivers/pinctrl/freescale/pinctrl-imx21.c
+++ b/drivers/pinctrl/freescale/pinctrl-imx21.c
@@ -325,7 +325,6 @@ static const struct of_device_id imx21_pinctrl_of_match[] = {
{ .compatible = "fsl,imx21-iomuxc", },
{ }
};
-MODULE_DEVICE_TABLE(of, imx21_pinctrl_of_match);
static struct platform_driver imx21_pinctrl_driver = {
.driver = {
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] pinctrl: imx21: Remove the MODULE_DEVICE_TABLE() macro
2016-07-06 13:25 [PATCH] pinctrl: imx21: Remove the MODULE_DEVICE_TABLE() macro Fabio Estevam
@ 2016-07-06 13:42 ` Linus Walleij
2016-07-06 14:38 ` Paul Gortmaker
2016-07-06 13:43 ` Arnd Bergmann
1 sibling, 1 reply; 5+ messages in thread
From: Linus Walleij @ 2016-07-06 13:42 UTC (permalink / raw)
To: Fabio Estevam; +Cc: Paul Gortmaker, Arnd Bergmann, linux-gpio@vger.kernel.org
On Wed, Jul 6, 2016 at 3:25 PM, Fabio Estevam <festevam@gmail.com> wrote:
> Commit e2756baa4217 ("pinctrl: imx21: make it explicitly non-modular")
> missed the removal of the MODULE_DEVICE_TABLE() macro causing the
> following build error:
>
> drivers/pinctrl/freescale/pinctrl-imx21.c:328:1: error: data definition has no type or storage class [-Werror]
> MODULE_DEVICE_TABLE(of, imx21_pinctrl_of_match);
>
> ,so remove the macro to fix this problem.
>
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
Patch applied with Arnd's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] pinctrl: imx21: Remove the MODULE_DEVICE_TABLE() macro
2016-07-06 13:42 ` Linus Walleij
@ 2016-07-06 14:38 ` Paul Gortmaker
2016-07-06 14:52 ` Linus Walleij
0 siblings, 1 reply; 5+ messages in thread
From: Paul Gortmaker @ 2016-07-06 14:38 UTC (permalink / raw)
To: Linus Walleij; +Cc: Fabio Estevam, Arnd Bergmann, linux-gpio@vger.kernel.org
[Re: [PATCH] pinctrl: imx21: Remove the MODULE_DEVICE_TABLE() macro] On 06/07/2016 (Wed 15:42) Linus Walleij wrote:
> On Wed, Jul 6, 2016 at 3:25 PM, Fabio Estevam <festevam@gmail.com> wrote:
>
> > Commit e2756baa4217 ("pinctrl: imx21: make it explicitly non-modular")
> > missed the removal of the MODULE_DEVICE_TABLE() macro causing the
> > following build error:
> >
> > drivers/pinctrl/freescale/pinctrl-imx21.c:328:1: error: data definition has no type or storage class [-Werror]
> > MODULE_DEVICE_TABLE(of, imx21_pinctrl_of_match);
> >
> > ,so remove the macro to fix this problem.
> >
> > Reported-by: Arnd Bergmann <arnd@arndb.de>
> > Signed-off-by: Fabio Estevam <festevam@gmail.com>
>
> Patch applied with Arnd's ACK.
Thanks and sorry this one snuck through. I'm going to add walking all
the various defconfigs to my build coverage akin to what linux-next does
overnight. It seems the allmodconfig builds didn't hit this file...
Paul.
--
>
> Yours,
> Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] pinctrl: imx21: Remove the MODULE_DEVICE_TABLE() macro
2016-07-06 14:38 ` Paul Gortmaker
@ 2016-07-06 14:52 ` Linus Walleij
0 siblings, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2016-07-06 14:52 UTC (permalink / raw)
To: Paul Gortmaker; +Cc: Fabio Estevam, Arnd Bergmann, linux-gpio@vger.kernel.org
n Wed, Jul 6, 2016 at 4:38 PM, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:
>> Patch applied with Arnd's ACK.
>
> Thanks and sorry this one snuck through. I'm going to add walking all
> the various defconfigs to my build coverage akin to what linux-next does
> overnight. It seems the allmodconfig builds didn't hit this file...
Don't worry. I'm a big fan of your work on cleaning up this mess and
surely I'm ready to do my part of making it happen.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] pinctrl: imx21: Remove the MODULE_DEVICE_TABLE() macro
2016-07-06 13:25 [PATCH] pinctrl: imx21: Remove the MODULE_DEVICE_TABLE() macro Fabio Estevam
2016-07-06 13:42 ` Linus Walleij
@ 2016-07-06 13:43 ` Arnd Bergmann
1 sibling, 0 replies; 5+ messages in thread
From: Arnd Bergmann @ 2016-07-06 13:43 UTC (permalink / raw)
To: Fabio Estevam; +Cc: linus.walleij, paul.gortmaker, linux-gpio
On Wednesday, July 6, 2016 10:25:17 AM CEST Fabio Estevam wrote:
> Commit e2756baa4217 ("pinctrl: imx21: make it explicitly non-modular")
> missed the removal of the MODULE_DEVICE_TABLE() macro causing the
> following build error:
>
> drivers/pinctrl/freescale/pinctrl-imx21.c:328:1: error: data definition has no type or storage class [-Werror]
> MODULE_DEVICE_TABLE(of, imx21_pinctrl_of_match);
>
> ,so remove the macro to fix this problem.
>
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
>
Acked-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-07-06 14:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-06 13:25 [PATCH] pinctrl: imx21: Remove the MODULE_DEVICE_TABLE() macro Fabio Estevam
2016-07-06 13:42 ` Linus Walleij
2016-07-06 14:38 ` Paul Gortmaker
2016-07-06 14:52 ` Linus Walleij
2016-07-06 13:43 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).