* [PATCH v1 1/1] pinctrl: intel: merrifield: Add missed header
@ 2016-08-02 15:18 Andy Shevchenko
2016-08-10 13:47 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2016-08-02 15:18 UTC (permalink / raw)
To: Mika Westerberg, linux-gpio, Linus Walleij; +Cc: Andy Shevchenko
On x86 builds the absense of <linux/io.h> makes static analyzer and compiler
unhappy which fails to build the driver.
CHECK drivers/pinctrl/intel/pinctrl-merrifield.c
drivers/pinctrl/intel/pinctrl-merrifield.c:518:17: error: undefined identifier 'readl'
drivers/pinctrl/intel/pinctrl-merrifield.c:570:17: error: undefined identifier 'readl'
drivers/pinctrl/intel/pinctrl-merrifield.c:575:9: error: undefined identifier 'writel'
drivers/pinctrl/intel/pinctrl-merrifield.c:645:17: error: undefined identifier 'readl'
CC drivers/pinctrl/intel/pinctrl-merrifield.o
drivers/pinctrl/intel/pinctrl-merrifield.c: In function ‘mrfld_pin_dbg_show’:
drivers/pinctrl/intel/pinctrl-merrifield.c:518:10: error: implicit declaration of function ‘readl’ [-Werror=implicit-function-declaration]
value = readl(bufcfg);
^
drivers/pinctrl/intel/pinctrl-merrifield.c: In function ‘mrfld_update_bufcfg’:
drivers/pinctrl/intel/pinctrl-merrifield.c:575:2: error: implicit declaration of function ‘writel’ [-Werror=implicit-function-declaration]
writel(value, bufcfg);
^
cc1: some warnings being treated as errors
Add header to the top of the module.
Fixes: 4e80c8f50574 ("pinctrl: intel: Add Intel Merrifield pin controller support")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/pinctrl/intel/pinctrl-merrifield.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/intel/pinctrl-merrifield.c b/drivers/pinctrl/intel/pinctrl-merrifield.c
index eb4990f..7fb7656 100644
--- a/drivers/pinctrl/intel/pinctrl-merrifield.c
+++ b/drivers/pinctrl/intel/pinctrl-merrifield.c
@@ -11,6 +11,7 @@
#include <linux/bitops.h>
#include <linux/err.h>
+#include <linux/io.h>
#include <linux/module.h>
#include <linux/platform_device.h>
#include <linux/pinctrl/pinconf.h>
--
2.8.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1 1/1] pinctrl: intel: merrifield: Add missed header
2016-08-02 15:18 [PATCH v1 1/1] pinctrl: intel: merrifield: Add missed header Andy Shevchenko
@ 2016-08-10 13:47 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2016-08-10 13:47 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Mika Westerberg, linux-gpio@vger.kernel.org
On Tue, Aug 2, 2016 at 5:18 PM, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> On x86 builds the absense of <linux/io.h> makes static analyzer and compiler
> unhappy which fails to build the driver.
Patch applied. Thanks a lot Andy!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-10 19:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-02 15:18 [PATCH v1 1/1] pinctrl: intel: merrifield: Add missed header Andy Shevchenko
2016-08-10 13:47 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).