From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartosz Golaszewski Subject: [PATCH v4 0/5] gpio: pca953x: code refactoring Date: Wed, 7 Sep 2016 16:49:25 +0200 Message-ID: <1473259770-26224-1-git-send-email-bgolaszewski@baylibre.com> Return-path: Received: from mail-wm0-f48.google.com ([74.125.82.48]:38893 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753488AbcIGOtk (ORCPT ); Wed, 7 Sep 2016 10:49:40 -0400 Received: by mail-wm0-f48.google.com with SMTP id 1so37083605wmz.1 for ; Wed, 07 Sep 2016 07:49:39 -0700 (PDT) Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Linus Walleij , Alexandre Courbot , Andy Shevchenko , Vignesh R , Yong Li , Geert Uytterhoeven Cc: linux-gpio , LKML , Bartosz Golaszewski I'm working on converting the pca953x driver to using regmap, but since it's not a trivial task I figured I'd post a couple refactoring patches I did so far for 4.9. The first patch just fixes a couple coding style issues. The second removes a couple unnecessary switches. Last three refactor the read/write_regs functions to avoid if-elses by using function pointers to smaller, specialized routines. Tested with pca9534 and pca9535 chips. v1 -> v2: - constified the offset structures in patch 2/5 v2 -> v3: - modified the order of the patches so that minor coding style fixes no longer create noise for the later changes - moved the **_write_regs_16() assignments to where other variants are assigned v3 -> v4: - minor style fixes Bartosz Golaszewski (5): gpio: pca953x: code shrink gpio: pca953x: refactor pca953x_write_regs() gpio: pca953x: refactor pca953x_read_regs() gpio: pca953x: remove an unused variable gpio: pca953x: coding style fixes drivers/gpio/gpio-pca953x.c | 271 ++++++++++++++++++++++---------------------- 1 file changed, 136 insertions(+), 135 deletions(-) -- 2.7.4