* [PATCH] gpio: gpiolib: fix an incorrect use of WARN_ON()
@ 2016-09-09 9:19 Bartosz Golaszewski
2016-09-12 12:51 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Bartosz Golaszewski @ 2016-09-09 9:19 UTC (permalink / raw)
To: Linus Walleij, Alexandre Courbot, Andy Shevchenko, Vignesh R,
Yong Li, Geert Uytterhoeven
Cc: linux-gpio, LKML, Bartosz Golaszewski
This breaks the build due to the format string being passed as
argument. Fix it by using WARN().
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
NOTE This patch applies on top of linux-gpio devel branch.
drivers/gpio/gpiolib.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 95effec..384ed0a 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -1618,8 +1618,8 @@ int _gpiochip_irqchip_add(struct gpio_chip *gpiochip,
* used to configure the interrupts, as you may end-up with
* conflicting triggers. Tell the user, and reset to NONE.
*/
- if (WARN_ON(of_node && type != IRQ_TYPE_NONE,
- "%s: Ignoring %d default trigger\n", of_node->full_name))
+ if (WARN(of_node && type != IRQ_TYPE_NONE,
+ "%s: Ignoring default trigger\n", of_node->full_name))
type = IRQ_TYPE_NONE;
gpiochip->irqchip = irqchip;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gpio: gpiolib: fix an incorrect use of WARN_ON()
2016-09-09 9:19 [PATCH] gpio: gpiolib: fix an incorrect use of WARN_ON() Bartosz Golaszewski
@ 2016-09-12 12:51 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2016-09-12 12:51 UTC (permalink / raw)
To: Bartosz Golaszewski, Marc Zyngier
Cc: Alexandre Courbot, Andy Shevchenko, Vignesh R, Yong Li,
Geert Uytterhoeven, linux-gpio, LKML
On Fri, Sep 9, 2016 at 11:19 AM, Bartosz Golaszewski
<bgolaszewski@baylibre.com> wrote:
> This breaks the build due to the format string being passed as
> argument. Fix it by using WARN().
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
> NOTE This patch applies on top of linux-gpio devel branch.
Thanks, Marc realized the mistake and sent a v2 patch so I
have already fixed this up, sorry for leaving the tree in a mess
over the weekend.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-12 12:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-09 9:19 [PATCH] gpio: gpiolib: fix an incorrect use of WARN_ON() Bartosz Golaszewski
2016-09-12 12:51 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).