* [PATCH] gpio: max77620: Remove unused fields from struct max77620_gpio
@ 2016-09-25 12:44 Axel Lin
2016-09-26 12:43 ` Laxman Dewangan
2016-10-06 8:15 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2016-09-25 12:44 UTC (permalink / raw)
To: Linus Walleij
Cc: Laxman Dewangan, Venkat Reddy Talla, Alexandre Courbot,
linux-gpio, Axel Lin
Current code does not use gpio_irq/irq_base/gpio_base fields from
struct max77620_gpio, so remove them.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/gpio/gpio-max77620.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/gpio/gpio-max77620.c b/drivers/gpio/gpio-max77620.c
index b46b436..df03586 100644
--- a/drivers/gpio/gpio-max77620.c
+++ b/drivers/gpio/gpio-max77620.c
@@ -21,9 +21,6 @@ struct max77620_gpio {
struct gpio_chip gpio_chip;
struct regmap *rmap;
struct device *dev;
- int gpio_irq;
- int irq_base;
- int gpio_base;
};
static const struct regmap_irq max77620_gpio_irqs[] = {
@@ -254,7 +251,6 @@ static int max77620_gpio_probe(struct platform_device *pdev)
mgpio->rmap = chip->rmap;
mgpio->dev = &pdev->dev;
- mgpio->gpio_irq = gpio_irq;
mgpio->gpio_chip.label = pdev->name;
mgpio->gpio_chip.parent = &pdev->dev;
@@ -268,7 +264,6 @@ static int max77620_gpio_probe(struct platform_device *pdev)
mgpio->gpio_chip.ngpio = MAX77620_GPIO_NR;
mgpio->gpio_chip.can_sleep = 1;
mgpio->gpio_chip.base = -1;
- mgpio->irq_base = -1;
#ifdef CONFIG_OF_GPIO
mgpio->gpio_chip.of_node = pdev->dev.parent->of_node;
#endif
@@ -281,9 +276,8 @@ static int max77620_gpio_probe(struct platform_device *pdev)
return ret;
}
- mgpio->gpio_base = mgpio->gpio_chip.base;
- ret = devm_regmap_add_irq_chip(&pdev->dev, chip->rmap, mgpio->gpio_irq,
- IRQF_ONESHOT, mgpio->irq_base,
+ ret = devm_regmap_add_irq_chip(&pdev->dev, chip->rmap, gpio_irq,
+ IRQF_ONESHOT, -1,
&max77620_gpio_irq_chip,
&chip->gpio_irq_data);
if (ret < 0) {
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] gpio: max77620: Remove unused fields from struct max77620_gpio
2016-09-25 12:44 [PATCH] gpio: max77620: Remove unused fields from struct max77620_gpio Axel Lin
@ 2016-09-26 12:43 ` Laxman Dewangan
2016-10-06 8:15 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Laxman Dewangan @ 2016-09-26 12:43 UTC (permalink / raw)
To: Axel Lin, Linus Walleij; +Cc: Venkat Reddy Talla, Alexandre Courbot, linux-gpio
On Sunday 25 September 2016 06:14 PM, Axel Lin wrote:
> Current code does not use gpio_irq/irq_base/gpio_base fields from
> struct max77620_gpio, so remove them.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information. Any unauthorized review, use, disclosure or distribution
is prohibited. If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: max77620: Remove unused fields from struct max77620_gpio
2016-09-25 12:44 [PATCH] gpio: max77620: Remove unused fields from struct max77620_gpio Axel Lin
2016-09-26 12:43 ` Laxman Dewangan
@ 2016-10-06 8:15 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2016-10-06 8:15 UTC (permalink / raw)
To: Axel Lin
Cc: Laxman Dewangan, Venkat Reddy Talla, Alexandre Courbot,
linux-gpio@vger.kernel.org
On Sun, Sep 25, 2016 at 2:44 PM, Axel Lin <axel.lin@ingics.com> wrote:
> Current code does not use gpio_irq/irq_base/gpio_base fields from
> struct max77620_gpio, so remove them.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Patch applied with Laxman's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-06 8:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-25 12:44 [PATCH] gpio: max77620: Remove unused fields from struct max77620_gpio Axel Lin
2016-09-26 12:43 ` Laxman Dewangan
2016-10-06 8:15 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).