From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Tan Jui Nee <jui.nee.tan@intel.com>,
mika.westerberg@linux.intel.com, heikki.krogerus@linux.intel.com,
tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
x86@kernel.org, ptyser@xes-inc.com, lee.jones@linaro.org,
linus.walleij@linaro.org
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
jonathan.yong@intel.com, ong.hock.yu@intel.com,
tony.luck@intel.com, wan.ahmad.zainie.wan.mohamad@intel.com
Subject: Re: [PATCH v8 4/6] mfd: move enum lpc_chipsets into lpc_ich.h
Date: Wed, 12 Oct 2016 13:24:49 +0300 [thread overview]
Message-ID: <1476267889.11323.446.camel@linux.intel.com> (raw)
In-Reply-To: <1476255066-22653-5-git-send-email-jui.nee.tan@intel.com>
On Wed, 2016-10-12 at 14:51 +0800, Tan Jui Nee wrote:
> Move the enum's definition into a standalone header file which can be
> used
> wherever its definition is needed.
>
> --- a/include/linux/mfd/lpc_ich.h
> +++ b/include/linux/mfd/lpc_ich.h
> @@ -43,4 +43,75 @@ struct lpc_ich_info {
> u8 use_gpio;
> };
>
> +/* chipset related info */
> +enum lpc_chipsets {
Maybe it worth to add that the list should be not shuffled, new items
should go at the end.
But it is up to you.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2016-10-12 10:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-12 6:51 [PATCH v8 0/6] inctrl/broxton: enable platform device in the absent of ACPI enumeration Tan Jui Nee
2016-10-12 6:51 ` [PATCH v8 1/6] x86/platform/p2sb: New Primary to Sideband bridge support driver for Intel SOC's Tan Jui Nee
2016-10-12 6:51 ` [PATCH v8 2/6] mfd: lpc_ich: Rename lpc-ich driver Tan Jui Nee
2016-10-26 13:02 ` Lee Jones
2016-10-12 6:51 ` [PATCH v8 3/6] x86/intel-ivi: Add Intel In-Vehicle Infotainment (IVI) systems used in cars support Tan Jui Nee
2016-10-12 10:29 ` Andy Shevchenko
2016-10-12 6:51 ` [PATCH v8 4/6] mfd: move enum lpc_chipsets into lpc_ich.h Tan Jui Nee
2016-10-12 10:24 ` Andy Shevchenko [this message]
2016-10-12 6:51 ` [PATCH v8 5/6] mfd: lpc_ich: Add Device IDs for Intel Apollo Lake PCH Tan Jui Nee
2016-10-26 13:06 ` Lee Jones
2016-10-26 13:06 ` Lee Jones
2016-10-26 15:00 ` Andy Shevchenko
2016-10-26 16:18 ` Lee Jones
2016-10-12 6:51 ` [PATCH v8 6/6] mfd: lpc_ich: Add support for Intel Apollo Lake GPIO pinctrl in non-ACPI system Tan Jui Nee
2016-10-12 10:23 ` Andy Shevchenko
2016-10-20 11:57 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476267889.11323.446.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jonathan.yong@intel.com \
--cc=jui.nee.tan@intel.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=mingo@redhat.com \
--cc=ong.hock.yu@intel.com \
--cc=ptyser@xes-inc.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=wan.ahmad.zainie.wan.mohamad@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).