From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1CCDC433E0 for ; Tue, 23 Feb 2021 10:24:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A7AF364E57 for ; Tue, 23 Feb 2021 10:24:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230472AbhBWKYw (ORCPT ); Tue, 23 Feb 2021 05:24:52 -0500 Received: from gloria.sntech.de ([185.11.138.130]:57266 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230142AbhBWKYt (ORCPT ); Tue, 23 Feb 2021 05:24:49 -0500 Received: from ip5f5aa64a.dynamic.kabel-deutschland.de ([95.90.166.74] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lEUrQ-00006b-AO; Tue, 23 Feb 2021 11:24:08 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: linus.walleij@linaro.org, Jianqun Xu Cc: linux-gpio@vger.kernel.org, linux-rockchip@lists.infradead.org, Jianqun Xu , Ziyuan Xu Subject: Re: [PATCH] pinctrl: rockchip: clear int status when driver probed Date: Tue, 23 Feb 2021 11:24:07 +0100 Message-ID: <14836062.ZYm5mLc6kN@diego> In-Reply-To: <20210223101937.273085-1-jay.xu@rock-chips.com> References: <20210223101937.273085-1-jay.xu@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Am Dienstag, 23. Februar 2021, 11:19:37 CET schrieb Jianqun Xu: > Some devices may do gpio interrupt trigger and make an int status before > pinctrl driver probed, then the gpio handler will keep complain untill > the device driver works to stop trigger. > > Signed-off-by: Ziyuan Xu > Signed-off-by: Jianqun Xu Reviewed-by: Heiko Stuebner > --- > drivers/pinctrl/pinctrl-rockchip.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c > index aa1a1c850d05..ec4cb88572cf 100644 > --- a/drivers/pinctrl/pinctrl-rockchip.c > +++ b/drivers/pinctrl/pinctrl-rockchip.c > @@ -3433,6 +3433,7 @@ static int rockchip_interrupts_register(struct platform_device *pdev, > * things enabled, so for us that's all masked and all enabled. > */ > writel_relaxed(0xffffffff, bank->reg_base + GPIO_INTMASK); > + writel_relaxed(0xffffffff, bank->reg_base + GPIO_PORTS_EOI); > writel_relaxed(0xffffffff, bank->reg_base + GPIO_INTEN); > gc->mask_cache = 0xffffffff; > >